Skip to content

Hide Strategic and Notable groups from the API #23373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chrstinalin
Copy link
Contributor

@chrstinalin chrstinalin commented Apr 25, 2025

Fixes: mozilla/addons#14987

Description

Prevents strategic and notable groups from being exposed through the API.

Testing

  1. GETs to /api/v5/addons/addon/(int:id|string:slug|string:guid)/ should not expose the strategic or notable groups.
  2. Other promoted groups (excluding partner) should still be exposed.

Checklist

  • Add #ISSUENUM at the top of your PR to an existing open issue in the mozilla/addons repository.
  • Successfully verified the change locally.
  • The change is covered by automated tests, or otherwise indicated why doing so is unnecessary/impossible.

@diox
Copy link
Member

diox commented Apr 25, 2025

Spotlight should be public in the API - it has no badge, but we depend on it being public to hide the installation warning in the frontend

@chrstinalin chrstinalin changed the title Set Spotlight, Strategic, and Notable groups to is_public=False Set Strategic and Notable groups to is_public=False Apr 25, 2025
@chrstinalin chrstinalin requested review from a team and diox and removed request for a team April 25, 2025 21:11
@chrstinalin chrstinalin changed the title Set Strategic and Notable groups to is_public=False Hide Strategic and Notable groups from the API Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Do not expose information about an add-on being Notable or Strategic in API
2 participants