Only Show Recommended/By Firefox in Devhub

[chrstinalin]

Fixes: mozilla/addons#15548

Description

Hides promoted groups other than Recommended/By Firefox from appearing in DevHub --

-- But is still visible in Reviewer Tools.

Testing

1. Add 'By Firefox' and/or 'Recommended' group to an add-on.
2. Add any other promoted groups.
3. Approve the add-on.
4. All groups should be visible in reviewer tools.
5. Only 'By Firefox' and/or 'Recommended' should be visible in DevHub status.

Checklist

• Add #ISSUENUM at the top of your PR to an existing open issue in the mozilla/addons repository.
• Successfully verified the change locally.
• The change is covered by automated tests, or otherwise indicated why doing so is unnecessary/impossible.
• Add before and after screenshots (Only for changes that impact the UI).

[KevinMind]

This should be a database field. Please don't add more logic based on the constants as we should be aiming to remove those from the codebase entirely relatively soon.

[diox]

Is there any reason not to simply follow is_public here ? I don't think developers should see more information than what we're exposing in the API.

[chrstinalin]

Is there any reason not to simply follow is_public here ? I don't think developers should see more information than what we're exposing in the API.

That's how I had it originally for this PR, but because of #23373 (comment), spotlight would be visible as well. If that's fine, I'll just revert it back to how I had it. @diox

[diox]

mmm, I suggested is_public but actually what we really want here is to only show groups that are badged (checking is_public on top of that shouldn't hurt, but it should be redundant: if a group has a badge, it should be public...) - so Spotlight shouldn't be there.