Skip to content

[ImportVerilog] Convert the unpacked array to a simple bit vector #8392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[ImportVerilog] Convert the unpacked array to a simple bit vector #8392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3087094
unpacked array to simple bit vector
AnnuCode Apr 4, 2025
41571e1
minor correction
AnnuCode Apr 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions lib/Conversion/ImportVerilog/Expressions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1272,6 +1272,14 @@ Value Context::convertToSimpleBitVector(Value value) {
value);
}
}
if (auto unpacked = dyn_cast<moore::UnpackedType>(value.getType())) {
if (auto bits = unpacked.getBitSize()) {
auto sbvType =
moore::IntType::get(value.getContext(), *bits, unpacked.getDomain());
return builder.create<moore::ConversionOp>(value.getLoc(), sbvType,
value);
}
}

mlir::emitError(value.getLoc()) << "expression of type " << value.getType()
<< " cannot be cast to a simple bit vector";
Expand Down
20 changes: 20 additions & 0 deletions test/Conversion/ImportVerilog/basic.sv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -709,6 +709,10 @@ module Expressions;
bit [1:0][31:0] arrayInt;
// CHECK: %uarrayInt = moore.variable : <uarray<2 x i32>>
bit [31:0] uarrayInt [2];
// CHECK: %arr1 = moore.variable : <uarray<2 x i32>
bit [31:0] arr1 [2];
// CHECK: %arr2 = moore.variable : <uarray<2 x i32>
bit [31:0] arr2 [2];
// CHECK: %m = moore.variable : <l4>
logic [3:0] m;

Expand Down Expand Up @@ -1119,6 +1123,22 @@ module Expressions;
// CHECK: [[TMP2:%.+]] = moore.read %e
// CHECK: moore.eq [[TMP1]], [[TMP2]] : l32 -> l1
y = d == e;

// CHECK: [[TMP0:%.+]] = moore.constant 43
// CHECK: [[TMP1:%.+]] = moore.constant 9002
// CHECK: moore.array_create [[TMP0]], [[TMP1]] : !moore.i32, !moore.i32 -> uarray<2 x i32>
arr1 = '{43, 9002};
// CHECK: [[TMP0:%.+]] = moore.constant 43
// CHECK: [[TMP1:%.+]] = moore.constant 9002
// CHECK: moore.array_create [[TMP0]], [[TMP1]] : !moore.i32, !moore.i32 -> uarray<2 x i32>
arr2 = '{43, 9002};
// CHECK: [[TMP1:%.+]] = moore.read %arr1 : <uarray<2 x i32>>
// CHECK: [[TMP2:%.+]] = moore.read %arr2 : <uarray<2 x i32>>
// CHECK: [[TMP3:%.+]] = moore.conversion [[TMP1:%.+]] : !moore.uarray<2 x i32> -> !moore.i64
// CHECK: [[TMP4:%.+]] = moore.conversion [[TMP2:%.+]] : !moore.uarray<2 x i32> -> !moore.i64
// CHECK: [[TMP5:%.+]] = moore.eq [[TMP3:%.+]], [[TMP4:%.+]] : i64 -> i1
x = arr1 == arr2;

// CHECK: [[TMP1:%.+]] = moore.read %a
// CHECK: [[TMP2:%.+]] = moore.read %b
// CHECK: moore.ne [[TMP1]], [[TMP2]] : i32 -> i1
Expand Down
Loading