-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Fixed Test case failure in PR 29037 - [2025/04/21] Candidate #29049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Test case failure in PR 29037 - [2025/04/21] Candidate #29049
Conversation
Hey there @@HarishKumarSF4517! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
src/Controls/src/Core/Compatibility/Handlers/FlyoutPage/iOS/PhoneFlyoutPageRenderer.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PureWeen @bhavanesh2001 As per the current implementation on Windows, the GaussianBlurEffect only supports applying blur to the entire visual content, as documented here: https://learn.microsoft.com/en-us/windows/win32/direct2d/gaussian-blur. Therefore, the current output image on Windows is expected and aligns with the platform's behavior, as there is no available API to apply the blur effect selectively based on corner values. Shall we proceed with the current image? Please share your thoughts or concerns. |
@anandhan-rajagopal Keeping the snapshot doesn’t seem right to me. The expected behavior is that the blur should be applied within the specified radius. Windows not supporting that directly is more of a limitation we should handle, not something we should lock in as the correct output. maui/src/Graphics/src/Graphics/IBlurrableCanvas.cs Lines 3 to 6 in b43b974
|
Hi @bhavanesh2001 , Thank you for your feedback. For now, I have decided to consider the Windows issues separately and have excluded Windows from the test case accordingly, along with linking the relevant issue report |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Description
This pull request includes changes to resolve the test failures on Candidate PR(#29037) and included the copilot code suggestion on the PhoneFlyoutPageRenderer class to improve code clarity and correctness.
Test cases:
Issue8632 - Changed the conditional compilation directive in Issue8632.cs from || (logical OR) to && (logical AND) to refine the conditions under which the test is excluded.
Issue28536 - Added base line image generated from CI.