[2025/04/21] Candidate - In Flight Branch #29037
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion (#28746) * Fixed-VS-Picker * Added-iOS-SnapShot
…r/Footer After Changing ItemsLayout in CV2 (#28890) * [Testing] Fix for flaky UITests in CI that occasionally fail - 7 (#28764) * improve stability to flaky tests * Updated changes * Update CarouselViewUITests.LoopNoFreeze.cs * Update EntryClearButtonColorShouldMatchTextColor.png * Update CommunityToolkit.Maui reference in sample content template (#28510) * Update CommunityToolkit.Maui & Mvvm reference in template * Fix MAUI Toolkit breaking changes * Debump MVVM Toolkit * Update MauiApp.1.csproj * Update package version in MauiApp.1.csproj * Add framework-specific validation flags and update package version * Swap TextValidationBehavior Flags for frameworks * [Testing] Fix for flaky UITests in CI that occasionally fail - 6 (#28747) * Fixed flaky tests related to entry control * Update src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue25473.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue25473.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fixed 19500 test * reverted the common changes * Fix typo in Issue19500.cs comments --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Shane Neuville <shneuvil@microsoft.com> * Update dependencies from https://github.com/dotnet/xharness build 20250403.2 (#28819) Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 9.0.0-prerelease.25167.9 -> To Version 9.0.0-prerelease.25203.2 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update Issue19509.cs (#28807) * Resave mac tabbedpage images (#28803) * Fixed ListView leak caused by not disposed ContextActionsCell (#28702) * Fixed something that looks like copy/paste error * Fixed memory leak caused by not disposed ContextActionsCell * [Testing] Fix for flaky UITests in CI that occasionally fail - 8 (#28828) * improve stability to flaky test * Update Issue7678.cs * Fixed the TargetInvocationException Occurs When Selecting Header/Footer After Changing ItemsLayout in CV2 * Included the test case and sample for the fix * Added the test case for footer --------- Co-authored-by: HarishKumarSF4517 <harish.kumar@syncfusion.com> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> Co-authored-by: Anandhan Rajagopal <97146406+anandhan-rajagopal@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Shane Neuville <shneuvil@microsoft.com> Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Vitaly Knyazev <VitalyKnyazev@users.noreply.github.com>
… CV2 (#28641) * Fixed-Header-Footer-Issues-In-CV2 * Modified-Test * Android-Specific Test Restriction * Modified-fix * Added-Comment
* Fixed android blur issue * added issue link
* Update to Windows App SDK 1.7 https://github.com/microsoft/microsoft-ui-xaml/releases/tag/winui3/release/1.7.0 * nits * Update Directory.Build.targets * Upgrade 1.7.0 to 1.7.1 --------- Co-authored-by: Matthew Leibowitz <mattleibow@live.com>
…ehavior property (#28884) * Fix added * fix updated * test added * test modified * null check added
…abbedPage (#28844) * Fixed the Incorrect Text Color Applied to Selected Tab in TabbedPage on Android * Added pending snap and optimized the fix
…d MIME format (#28842) * [iOS] Fix for 15562 ( File.ContentType from MediaPicker is not in MIME format ). * [iOS] Fix for 15562 (File.ContentType from MediaPicker is not in MIME format) * [iOS] Fix for 15562 (File.ContentType from MediaPicker is not in MIME format) * [iOS] Fix for 15562 ( File.ContentType from MediaPicker is not in MIME format )
* [XC] add IRootObjectProvider this was never meant to be public, but it was. and people are using it - fixes #16881 * ignore case
…r updating to WinUI SDK 1.7 (#28996) * Fixed flyout content width issue * Updated details
This reverts commit dfeadeb.
There was a problem hiding this comment.
Copilot reviewed 40 out of 46 changed files in this pull request and generated 1 comment.
Files not reviewed (6)
- eng/Versions.props: Language not supported
- src/Controls/src/Xaml/PublicAPI/net-android/PublicAPI.Unshipped.txt: Language not supported
- src/Controls/src/Xaml/PublicAPI/net-ios/PublicAPI.Unshipped.txt: Language not supported
- src/Controls/src/Xaml/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt: Language not supported
- src/Controls/src/Xaml/PublicAPI/net-tizen/PublicAPI.Unshipped.txt: Language not supported
- src/Controls/src/Xaml/PublicAPI/net-windows/PublicAPI.Unshipped.txt: Language not supported
| FlyoutPage flyoutPage = Element as FlyoutPage; | ||
| if (flyoutPage == null) | ||
| return; | ||
| FlyoutLayoutBehavior flyoutBehavior = FlyoutPage.FlyoutLayoutBehavior; |
There was a problem hiding this comment.
Use the 'flyoutPage' instance instead of the 'FlyoutPage' type when accessing the FlyoutLayoutBehavior property. Change this line to 'FlyoutLayoutBehavior flyoutBehavior = flyoutPage.FlyoutLayoutBehavior;'.
Suggested change
| FlyoutLayoutBehavior flyoutBehavior = FlyoutPage.FlyoutLayoutBehavior; | |
| FlyoutLayoutBehavior flyoutBehavior = flyoutPage.FlyoutLayoutBehavior; |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
| @@ -0,0 +1,22 @@ | |||
| #if TEST_FAILS_ON_IOS || TEST_FAILS_ON_CATALYST // https://github.com/dotnet/maui/issues/28910 | |||
There was a problem hiding this comment.
This should be #if TEST_FAILS_ON_IOS && TEST_FAILS_ON_CATALYST? Test ran on mac and iOS in CI
There was a problem hiding this comment.
@bhavanesh2001 Thanks for the suggestion, and it's addressed in this PR.
#29049
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Only PRs related to fixing this branch should be merge here
For more information about inflight process check
https://github.com/dotnet/maui/wiki/Inflight-Branch-Process