[FLINK-37698] Rename fromSchedulerNg to fromWithinExecutionGraph

[beliefer]

What is the purpose of the change

This PR aims to rename fromSchedulerNg to fromWithinExecutionGraph.
The Java doc tells me the meaning of fromSchedulerNg, please refer

flink/flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java

Line 1151 in 3cfc211

* @param fromSchedulerNg Indicating whether the failure is from the SchedulerNg. It should be

But I found the behavior of the caller of processFail is inconsistent with the comments for fromSchedulerNg.
Please see:

flink/flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/DefaultExecutionGraph.java

Line 1481 in 3cfc211

true);

As the Java doc said, we should pass false in DefaultExecutionGraph.
So I rename fromSchedulerNg to fromWithinExecutionGraph and make the behavior is consistent with the Java doc.

Brief change log

Rename fromSchedulerNg to fromWithinExecutionGraph.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): (no)
• The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
• The serializers: (no)
• The runtime per-record code paths (performance sensitive): (no)
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
• The S3 file system connector: (no)

Documentation

• Does this pull request introduce a new feature? (no)

[flinkbot]

CI report:

• f7fe48f Azure: SUCCESS

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot run azure re-run the last Azure build

[beliefer]

@flinkbot run azure

[beliefer]

ping @GJL @zhuzhurk cc @1996fanrui @davidradl @GOODBOY008

[zhuzhurk]

The fromSchedulerNg parameter was introduced to flag whether failure handling originated from the Flink scheduler itself. This flag eliminates redundant failure notifications to the scheduler (e.g., via notifySchedulerNgAboutInternalTaskFailure(...)), as the scheduler already initiates the process. Therefore, retaining the current parameter name is logically consistent.

[beliefer]

The fromSchedulerNg parameter was introduced to flag whether failure handling originated from the Flink scheduler itself. This flag eliminates redundant failure notifications to the scheduler (e.g., via notifySchedulerNgAboutInternalTaskFailure(...)), as the scheduler already initiates the process. Therefore, retaining the current parameter name is logically consistent.

I know the original meaning. Could you take a look at the description?