Skip to content

Commit f7fe48f

Browse files
committed
[FLINK-37698] Rename fromSchedulerNg to fromWithinExecutionGraph
1 parent b37c985 commit f7fe48f

File tree

1 file changed

+12
-6
lines changed

1 file changed

+12
-6
lines changed

flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java

+12-6
Original file line numberDiff line numberDiff line change
@@ -975,8 +975,14 @@ void markFailed(
975975
Map<String, Accumulator<?, ?>> userAccumulators,
976976
IOMetrics metrics,
977977
boolean releasePartitions,
978-
boolean fromSchedulerNg) {
979-
processFail(t, cancelTask, userAccumulators, metrics, releasePartitions, fromSchedulerNg);
978+
boolean fromWithinExecutionGraph) {
979+
processFail(
980+
t,
981+
cancelTask,
982+
userAccumulators,
983+
metrics,
984+
releasePartitions,
985+
fromWithinExecutionGraph);
980986
}
981987

982988
@VisibleForTesting
@@ -1148,16 +1154,16 @@ private void processFail(Throwable t, boolean cancelTask) {
11481154
* @param metrics IO metrics
11491155
* @param releasePartitions Indicating whether to release result partitions produced by this
11501156
* execution. False if the task is FAILED in TaskManager, otherwise true.
1151-
* @param fromSchedulerNg Indicating whether the failure is from the SchedulerNg. It should be
1152-
* false if it is from within the ExecutionGraph.
1157+
* @param fromWithinExecutionGraph Indicating whether the failure is from within the
1158+
* ExecutionGraph. It should be true if it is from within the ExecutionGraph.
11531159
*/
11541160
private void processFail(
11551161
Throwable t,
11561162
boolean cancelTask,
11571163
Map<String, Accumulator<?, ?>> userAccumulators,
11581164
IOMetrics metrics,
11591165
boolean releasePartitions,
1160-
boolean fromSchedulerNg) {
1166+
boolean fromWithinExecutionGraph) {
11611167

11621168
assertRunningInJobMasterMainThread();
11631169

@@ -1185,7 +1191,7 @@ private void processFail(
11851191
return;
11861192
}
11871193

1188-
if (!fromSchedulerNg) {
1194+
if (!fromWithinExecutionGraph) {
11891195
vertex.getExecutionGraphAccessor()
11901196
.notifySchedulerNgAboutInternalTaskFailure(
11911197
attemptId, t, cancelTask, releasePartitions);

0 commit comments

Comments
 (0)