Skip to content

chore(iast): check secure marks for SQLi #13239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

avara1986
Copy link
Member

@avara1986 avara1986 commented Apr 21, 2025

Overview

This PR adds validation for secure marks in SQL-related functions to improve SQL Injection detection in IAST. The changes ensure that secure marks are properly checked when analyzing SQL queries for potential vulnerabilities.

Changes

  • Added secure marks validation for SQL functions
  • Enhanced SQL Injection detection accuracy
  • Updated tests to cover secure marks validation scenarios

Testing Strategy

  • Added test cases for secure marks validation
  • Updated existing SQL Injection tests to include secure marks checks
  • Verified detection accuracy with both secure and insecure SQL queries

APPSEC-56947

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@avara1986 avara1986 added changelog/no-changelog A changelog entry is not required for this PR. ASM Application Security Monitoring labels Apr 21, 2025
Copy link
Contributor

github-actions bot commented Apr 21, 2025

CODEOWNERS have been resolved as:

tests/appsec/iast/test_iast_dbs.py                                      @DataDog/asm-python
tests/appsec/integrations/fixtures/patch_dbs.py                         @DataDog/asm-python
ddtrace/appsec/_iast/_ast/iastpatch.c                                   @DataDog/asm-python
ddtrace/appsec/_iast/_patch_modules.py                                  @DataDog/asm-python
hatch.toml                                                              @DataDog/python-guild
tests/appsec/iast/db_utils.py                                           @DataDog/asm-python
tests/appsec/iast/fixtures/taint_sinks/sql_injection_psycopg2.py        @DataDog/asm-python
tests/appsec/iast/fixtures/taint_sinks/sql_injection_pymysql.py         @DataDog/asm-python
tests/appsec/iast/iast_utils.py                                         @DataDog/asm-python
tests/appsec/iast/test_telemetry.py                                     @DataDog/asm-python

Copy link
Contributor

github-actions bot commented Apr 21, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 230 ± 1 ms.

The average import time from base is: 232 ± 2 ms.

The import time difference between this PR and base is: -1.88 ± 0.07 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 1.972 ms (0.86%)
ddtrace.bootstrap.sitecustomize 1.280 ms (0.56%)
ddtrace.bootstrap.preload 1.280 ms (0.56%)
ddtrace.internal.products 1.280 ms (0.56%)
ddtrace.internal.remoteconfig.client 0.612 ms (0.27%)
ddtrace 0.693 ms (0.30%)
ddtrace._logger 0.025 ms (0.01%)
logging 0.025 ms (0.01%)
traceback 0.025 ms (0.01%)
contextlib 0.025 ms (0.01%)

@pr-commenter
Copy link

pr-commenter bot commented Apr 21, 2025

Benchmarks

Benchmark execution time: 2025-04-23 07:36:01

Comparing candidate commit 8c49305 in PR branch avara1986/APPSEC-56947_securemarks_sqli with baseline commit 313fd41 in branch main.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 498 metrics, 8 unstable metrics.

scenario:iast_aspects-ospathdirname_aspect

  • 🟥 execution_time [+706.956ns; +918.066ns] or [+15.782%; +20.495%]

scenario:iast_aspects-ospathnormcase_aspect

  • 🟥 execution_time [+378.947ns; +451.264ns] or [+10.991%; +13.089%]

@avara1986 avara1986 marked this pull request as ready for review April 23, 2025 08:23
@avara1986 avara1986 requested review from a team as code owners April 23, 2025 08:23
avara1986 added a commit that referenced this pull request Apr 23, 2025
Related to: #13239 /
APPSEC-56947

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
avara1986 added a commit that referenced this pull request Apr 23, 2025
## Overview

This PR reorganizes functions in the IAST module to improve code
organization and maintainability. The changes include:

- Restructuring functions for better logical grouping
- Improving code organization
- No functional changes, purely organizational improvements

## Motivation

The reorganization helps improve code readability and maintainability by
grouping related functions together in a more logical way.

## Testing Strategy

Since this is a reorganization change with no functional modifications,
existing tests continue to validate the behavior remains unchanged.

Related to: #13239 /
APPSEC-56947

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants