-
Notifications
You must be signed in to change notification settings - Fork 430
chore(iast): check secure marks for SQLi #13239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 230 ± 1 ms. The average import time from base is: 232 ± 2 ms. The import time difference between this PR and base is: -1.88 ± 0.07 ms. Import time breakdownThe following import paths have shrunk:
|
BenchmarksBenchmark execution time: 2025-04-23 07:36:01 Comparing candidate commit 8c49305 in PR branch Found 0 performance improvements and 2 performance regressions! Performance is the same for 498 metrics, 8 unstable metrics. scenario:iast_aspects-ospathdirname_aspect
scenario:iast_aspects-ospathnormcase_aspect
|
Related to: #13239 / APPSEC-56947 ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
## Overview This PR reorganizes functions in the IAST module to improve code organization and maintainability. The changes include: - Restructuring functions for better logical grouping - Improving code organization - No functional changes, purely organizational improvements ## Motivation The reorganization helps improve code readability and maintainability by grouping related functions together in a more logical way. ## Testing Strategy Since this is a reorganization change with no functional modifications, existing tests continue to validate the behavior remains unchanged. Related to: #13239 / APPSEC-56947 ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Overview
This PR adds validation for secure marks in SQL-related functions to improve SQL Injection detection in IAST. The changes ensure that secure marks are properly checked when analyzing SQL queries for potential vulnerabilities.
Changes
Testing Strategy
APPSEC-56947
Checklist
Reviewer Checklist