Skip to content

chore(iast): restructure functions #13240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025
Merged

chore(iast): restructure functions #13240

merged 1 commit into from
Apr 23, 2025

Conversation

avara1986
Copy link
Member

@avara1986 avara1986 commented Apr 21, 2025

Overview

This PR reorganizes functions in the IAST module to improve code organization and maintainability. The changes include:

  • Restructuring functions for better logical grouping
  • Improving code organization
  • No functional changes, purely organizational improvements

Motivation

The reorganization helps improve code readability and maintainability by grouping related functions together in a more logical way.

Testing Strategy

Since this is a reorganization change with no functional modifications, existing tests continue to validate the behavior remains unchanged.

Related to: #13239 / APPSEC-56947

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@avara1986 avara1986 added changelog/no-changelog A changelog entry is not required for this PR. ASM Application Security Monitoring labels Apr 21, 2025
Copy link
Contributor

CODEOWNERS have been resolved as:

ddtrace/appsec/_iast/_handlers.py                                       @DataDog/asm-python
ddtrace/appsec/_iast/_iast_request_context_base.py                      @DataDog/asm-python
ddtrace/appsec/_iast/_metrics.py                                        @DataDog/asm-python
ddtrace/appsec/_iast/_patch.py                                          @DataDog/asm-python
ddtrace/appsec/_iast/_span_metrics.py                                   @DataDog/asm-python
ddtrace/appsec/_iast/_taint_utils.py                                    @DataDog/asm-python
ddtrace/appsec/_iast/_utils.py                                          @DataDog/asm-python

Copy link
Contributor

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 231 ± 3 ms.

The average import time from base is: 233 ± 3 ms.

The import time difference between this PR and base is: -1.6 ± 0.1 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 1.926 ms (0.83%)
ddtrace.bootstrap.sitecustomize 1.256 ms (0.54%)
ddtrace.bootstrap.preload 1.256 ms (0.54%)
ddtrace.internal.products 1.256 ms (0.54%)
ddtrace.internal.remoteconfig.client 0.608 ms (0.26%)
ddtrace 0.670 ms (0.29%)

@pr-commenter
Copy link

pr-commenter bot commented Apr 21, 2025

Benchmarks

Benchmark execution time: 2025-04-21 13:22:57

Comparing candidate commit a51c430 in PR branch avara1986/reorg_files with baseline commit 997a12e in branch main.

Found 0 performance improvements and 3 performance regressions! Performance is the same for 497 metrics, 8 unstable metrics.

scenario:iast_aspects-ospathdirname_aspect

  • 🟥 execution_time [+859.727ns; +975.602ns] or [+18.809%; +21.344%]

scenario:iast_aspects-ospathjoin_aspect

  • 🟥 execution_time [+633.443ns; +814.132ns] or [+10.493%; +13.486%]

scenario:telemetryaddmetric-1-rate-metric-1-times

  • 🟥 execution_time [+345.982ns; +427.145ns] or [+11.138%; +13.751%]

@avara1986 avara1986 marked this pull request as ready for review April 21, 2025 13:28
@avara1986 avara1986 requested a review from a team as a code owner April 21, 2025 13:28
@avara1986 avara1986 merged commit 225cacb into main Apr 23, 2025
471 of 473 checks passed
@avara1986 avara1986 deleted the avara1986/reorg_files branch April 23, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants