drivers: stepper: Fix stepper callbacks when using work_q #88835
+134
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bjarki-andreasen,
dipakgmx,
fabiobaltieri,
faxe1008,
jbehrensnx and
jilaypandya
jilaypandya
reviewed
Apr 20, 2025
tests/drivers/stepper/stepper_api/boards/native_sim_adi_tmc2209_work_q.overlay
Outdated
Show resolved
Hide resolved
| - platform:native_sim/native/64:DTC_OVERLAY_FILE="boards/native_sim_adi_tmc2209_work_q.overlay" | ||
| extra_configs: | ||
| - CONFIG_GPIO=y | ||
| - CONFIG_COUNTER=y |
There was a problem hiding this comment.
Suggested change
| - CONFIG_COUNTER=y |
| - platform:native_sim/native/64:DTC_OVERLAY_FILE="boards/native_sim_ti_drv84xx_work_q.overlay" | ||
| extra_configs: | ||
| - CONFIG_GPIO=y | ||
| - CONFIG_COUNTER=y |
There was a problem hiding this comment.
Suggested change
| - CONFIG_COUNTER=y |
tests/drivers/stepper/stepper_api/boards/native_sim_allegro_a4979_work_q.overlay
Outdated
Show resolved
Hide resolved
jilaypandya
reviewed
Apr 20, 2025
dipakgmx
reviewed
Apr 20, 2025
| POLL_AND_CHECK_SIGNAL(stepper_signal, stepper_event, STEPPER_EVENT_STEPS_COMPLETED, | ||
| K_MSEC(pos * 120)); | ||
| K_MSEC(pos * 130)); |
There was a problem hiding this comment.
Might as well make the 130 a define or a config
There was a problem hiding this comment.
Would adding Kconfig file with the parameter to the test and then adding the parameter to the testcase.yaml be a good solution?
There was a problem hiding this comment.
Yeah, that would be great actually. Thanks.
jbr7rr
force-pushed
the
fix-stepper-callbacks-when-using-work_q
branch
from
988f785 to
dfeb19e
Compare
Fix issue where stepper callbacks were not being called when using work_q. This was due to the steps being counted down before the work_q was rescheduled. Added additional unit tests to stepper_api to verify the fix. Signed-off-by: Josselin Bunt <josselin@sensible.health
jbr7rr
force-pushed
the
fix-stepper-callbacks-when-using-work_q
branch
from
dfeb19e to
5d6dced
Compare
faxe1008
reviewed
Apr 22, 2025
How? Unit test and fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue where stepper callbacks were not being called when using work_q. This was due to the steps being counted down before the work_q was rescheduled.
Added additional unit tests to stepper_api to verify the fix. Needed to increase the tolerance to 30% because of the timing of the work_q.
Fixes: #88821