-
Notifications
You must be signed in to change notification settings - Fork 498
Removed orphan assets #3567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed orphan assets #3567
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
✅ No broken links found! |
Documentation Link Check Results❌ Absolute links check failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We might want to subsequently make a PR to remove these assets from the git history completely as I imagine our repo contains a LOT of image / gif assets etc bloating it up.
* Removed orphan assets * Add image assets cleanup script with interactive confirmation (cherry picked from commit 1e1c5ee)
Describe changes
I implemented a script that finds and optionally deletes all assets that are not referenced in any markdown file. Couped with the work that was done in #3564, whcih also included deleting all orphaned markdown files, this should be a big step in cleaing up our docs.
Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes