Expand contributing guidelines #834
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
2 similar comments
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as abuse.
This comment was marked as abuse.
|
👍 |
| For this, we generally only consider arguments which are relevant to Zalando's | ||
| situation, as these are Zalando's guidelines, not generic guidelines for everyone. | ||
|
|
||
| So such changes generally will be suggested by Zalando employees. |
There was a problem hiding this comment.
Suggested change
| So such changes generally will be suggested by Zalando employees. | |
| So such changes typically (but not exclusively) will be suggested by Zalando employees. |
Co-authored-by: Thomas Frauenstein <thomas.frauenstein@zalando.de>
Co-authored-by: Paŭlo Ebermann <paul.ebermann@zalando.de>
Co-authored-by: Paŭlo Ebermann <paul.ebermann@zalando.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triggered by a note in #825, I want to make it clear what kind of pull requests are welcome.