fix: fix typescript error on defineItem fallback

[iyume]

Overview

Currently, the second signature of WxtStorage.defineItem method is incorrect that it doesn't respect the fallback value.

wxt/packages/storage/src/index.ts

Lines 748 to 754 in 4c35798

	defineItem<TValue, TMetadata extends Record<string, unknown> = {}>(
	key: StorageItemKey,
	): WxtStorageItem<TValue | null, TMetadata>;
	defineItem<TValue, TMetadata extends Record<string, unknown> = {}>(
	key: StorageItemKey,
	options: WxtStorageItemOptions<TValue>,
	): WxtStorageItem<TValue, TMetadata>;

The following examples show the bug clearly.

export const storageTodoItems = storage.defineItem<StorageTodoItem[]>(
  'local:StorageTodoItems',
  { fallback: [] },
)  // Type is StorageTodoItem[]

export const storageTodoItems = storage.defineItem<StorageTodoItem[]>(
  'local:StorageTodoItems',
)  // Type is StorageTodoItem[] | null

export const storageTodoItems = storage.defineItem<StorageTodoItem[]>(
  'local:StorageTodoItems', {}
)  // Type is StorageTodoItem[]. Wrong!!!

Manual Testing

export const storageTodoItems = storage.defineItem<StorageTodoItem[]>(
  'local:StorageTodoItems',
)  // Type is StorageTodoItem[] | null

export const storageTodoItems = storage.defineItem<StorageTodoItem[]>(
  'local:StorageTodoItems',
  {},
)  // Type is StorageTodoItem[] | null

export const storageTodoItems = storage.defineItem<StorageTodoItem[]>(
  'local:StorageTodoItems',
  { fallback: [] },
)  // Type is StorageTodoItem[]

Related Issue

[netlify]

✅ Deploy Preview for creative-fairy-df92c4 ready!

Name	Link
🔨 Latest commit	8cdfc35
🔍 Latest deploy log	https://app.netlify.com/sites/creative-fairy-df92c4/deploys/68072f2a9c318a0008888f0c
😎 Deploy Preview	https://deploy-preview-1601--creative-fairy-df92c4.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.