-
-
Notifications
You must be signed in to change notification settings - Fork 292
feat: Automatically update .wxt/types/paths.d.ts and web_accessible_resources manifest for favicon #1570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…esources manifest for favicon
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@aklinker1 |
@aklinker1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's name the module "favicon-permission" instead of "wxt-types". It will only ever have the code for the favicons permission.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you revert this file? The change isn't relevant to the PR. If you want to refactor this, please do it in a separate PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Overview
As suggested I've used WxtModules to implement this functionality.
Manual Testing
Related Issue
This PR closes #1559