test: Assert Android web global configuration #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other tasks use this anchor to avoid repetition.
dcalhoun
added
the
[Type] Automated Testing
dcalhoun
commented
Apr 21, 2025
| plugins: &plugins | ||
| - $CI_TOOLKIT_PLUGIN | ||
| - $NVM_PLUGIN | ||
| plugins: *plugins |
There was a problem hiding this comment.
This task appeared to be an outlier, where all other tasks rely upon this existing plugins anchor definition.
There was a problem hiding this comment.
Pull Request Overview
The PR adds comprehensive unit tests to assert the Android WebView global configuration and refines the build pipeline to include testing for the Android library.
- Added unit tests in EditorConfigurationTest.kt for validating configuration properties and JavaScript conversions of WebView global values.
- Updated the Buildkite pipeline to leverage plugin alias references and added a new step for testing the Android library.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| android/Gutenberg/src/test/java/org/wordpress/gutenberg/EditorConfigurationTest.kt | Added tests for configuration and WebViewGlobal conversion functions. |
| .buildkite/pipeline.yml | Refactored plugins usage and added an Android library test step. |
Files not reviewed (1)
- Makefile: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Assert Android WebView global configuration. Close CMM-283.
Why?
Avoid regressions within the regex and string manipulation.
How?
Add automated unit tests.
Testing Instructions
N/A, no user-facing changes.
Accessibility Testing Instructions
N/A, no user-facing changes.
Screenshots or screencast
N/A, no user-facing changes.