-
Notifications
You must be signed in to change notification settings - Fork 32
Improve Makefile #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
meator
wants to merge
5
commits into
wfeldt:master
Choose a base branch
from
meator:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Improve Makefile #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'll take some time to look trough it all. So far:
|
Thanks for your response! I'll remove the |
Just a heads-up: I haven't forgotten... |
Zopolis4
reviewed
Mar 24, 2025
This commit adds some features mentioned in General Conventions for Makefiles from the GNU make manual. It also allows the Makefile to use some variables form the environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes were inspired by
hwinfo
s Makefile and by the GNU make manual.The current version detection system and the changelog are fully dependent on git. This complicates building from release archives. One of my commits adds the
LIBX86EMU_VERSION
variable that makes things simpler, but this is not a good solution in my opinion. Another solution to this problem is to add aVERSION
file that would be incremented on every release. This wouldn't change the logic that much since Makefile already usesVERSION
.And while we're here, I'll ask some questions: Is the
$(ARCH)
variable used for anything in the current version oflibx86emu
s Makefile and do you have any specific reason to use/usr/lib64
instead of/usr/lib
?