fix: ensure setuid bit is set during installation #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@newtoallofthis123 Hey Ishan, I'm no longer on arch so can you just check if this is correct? Things look good to me. I'll wait for your confirmation before merging. |
|
Just installed an Arch vm to test this out! |
|
Okay it does seem to be working alright! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix setuid bit not being set when installing from AUR
This PR fixes issue #297 where the setuid bit is not being set when installing swhkd from AUR.
Changes made:
The changes ensure that the binary has the correct permissions (-rwsr-xr-x) after installation, both when installing manually and through the AUR package.