EDRLab Readium Mobile & Thorium Desktop Implementation #704
+62
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregoriopellegrino
approved these changes
Apr 23, 2025
gregoriopellegrino
approved these changes
Apr 23, 2025
gautierchomel
changed the title
|
To avoid conflicts while merging, I suggest we adopt an alphabetical order to present implementations. |
clapierre
approved these changes
Apr 23, 2025
|
I have a few comments from the perspective of a native English speaker. On line 118 it says: The book information panel contains Title, Identifier, Author, Publisher and Publication Date. After a separator, starts the section titles Accessibility Claims. A first toggle buttons allows to hide or show fields with no metadata, a second one to use descriptive statements instead of compacts. Then the list of accessibility information is visible, starting with Ways of reading, followed by Navigation, Additional accessibility information, Hazards and Conformance.I suggest: The book information panel contains Title, Identifier, Author, Publisher and Publication Date. After a separator, the section titled "Accessibility Claims" begins. The first toggle button allows to hide or show fields with no metadata, a second button allows to use descriptive instead of compac statementss. Then the list of accessibility information is visible, starting with Ways of reading, followed by Navigation, Additional accessibility information, Hazards and Conformance. Starting on line 134, the word informations is used in two places. This should be singular, i.e., information. On line 148 the word"interrogation " is used. I suggest using the word "question mark" |
mattgarrish
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.