Use ResizeObserver to cap level to player size #7108
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Use ResizeObserver when available in cap-level-controller.
Why is this Pull Request needed?
Using
capLevelToPlayerSize
to detect the media element dimensions forces layout. TheResizeObserver
avoids this speeding up player setup.Are there any points in the code the reviewer needs to double check?
Might want to debounce calling
this.detectPlayerSize
in the observer callback to avoid setting the level more than once when the media element size is animated by the browser during transitions like entering and exiting fullscreen.Resolves issues:
Checklist