regex added for Senegal sn-SN #2304
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2304 +/- ##
==========================================
- Coverage 99.95% 99.95% -0.01%
==========================================
Files 107 107
Lines 2454 2449 -5
Branches 619 619
==========================================
- Hits 2453 2448 -5
Partials 1 1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Please add SN to the list of locales of isPostalCode as well
| "license": "MIT", | ||
| "dependencies": { | ||
| "validator": "^13.11.0" | ||
| } |
There was a problem hiding this comment.
| "license": "MIT", | |
| "dependencies": { | |
| "validator": "^13.11.0" | |
| } | |
| "license": "MIT" |
| @@ -73,6 +73,7 @@ const patterns = { | |||
| US: /^\d{5}(-\d{4})?$/, | |||
| ZA: fourDigit, | |||
| ZM: fiveDigit, | |||
| SN: fiveDigit, | |||
There was a problem hiding this comment.
Please add tests for this as well. Also; can you provide a source for this?
| @@ -159,6 +159,7 @@ const phones = { | |||
| 'ar-YE': /^(((\+|00)9677|0?7)[0137]\d{7}|((\+|00)967|0)[1-7]\d{6})$/, | |||
| 'ar-EH': /^(\+?212|0)[\s\-]?(5288|5289)[\s\-]?\d{5}$/, | |||
| 'fa-AF': /^(\+93|0)?(2{1}[0-8]{1}|[3-5]{1}[0-4]{1})(\d{7})$/, | |||
| 'sn-SN': /^(221|00221|\+221)?(77|78|75|70|76)[0-9]{7}$/, | |||
There was a problem hiding this comment.
| 'sn-SN': /^(221|00221|\+221)?(77|78|75|70|76)[0-9]{7}$/, | |
| 'sn-SN': /^(\+?221|0)?(70|72|7[5-9])[0-9]{7}$/, |
According to the most recent document in https://www.itu.int/oth/T02020000B8/en , this should be the regular expression. I have also updated the first part to be more in line with other locales (even though there are major inconsistencies)
Tests should also be updated for this
Please also move this to it's proper alphabetical location, like in the README.
Validations added for Senegal - Issue #1761
CHECKLIST