Feat/form components changes #4311
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
🦋 Changeset detectedLatest commit: 0a09367 The changes in this PR will be included in the next version bump. This PR includes changesets to release 15 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dosubot
bot
added
the
size:L
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
Area: Components
|
View your CI Pipeline Execution ↗ for commit 0a09367.
☁️ Nx Cloud last updated this comment at |
|
Size Change: +333 B (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0a09367:
|
github-actions
bot
added
Area: Doc Site
PixeledCode
force-pushed
the
feat/form-components-changes
branch
from
b5c6a75 to
51277f5
Compare
Paste
|
||||||||||||||||||||||||||||||||||
| Project |
Paste
|
| Branch Review |
feat/form-components-changes
|
| Run status |
|
| Run duration | 06m 04s |
| Commit |
|
| Committer | PixeledCode |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
66
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
cypress/integration/link-checker/index.spec.ts • 1 failed test • Paste Docsite integration tests
| Test | Artifacts | |
|---|---|---|
| Broken link checker > recursively check all website links for any broken links |
Screenshots
|
|
github-actions
bot
added
the
Type: Documentation
Comment on lines
+33
to
+35
| color: "colorTextWeaker", | ||
| backgroundColor: "colorBackgroundBody", | ||
| boxShadow: "shadowBorderWeak", | ||
| boxShadow: "shadowBorderWeaker", |
There was a problem hiding this comment.
Suggestion: All the loading styles for buttons inherit from baseLoadingStyles right? If the color and boxShadow are denied there could we clean the button variants up here by removing them? Seems unnecessary to define them a second time. The only time we'd need to override it is for Inverse which is currently being done.
| </Box> | ||
|
|
||
| <Box as="span" hidden={!selected}> | ||
| <SelectedIcon decorative color={highlighted && selected ? "colorTextIcon" : "colorTextPrimary"} /> |
There was a problem hiding this comment.
issue: I don't see any selected icon in the combobox. Could you share the design plz
| element={`${element}_OPTIONAL_TEXT`} | ||
| > | ||
| {" "} | ||
| (optional) |
There was a problem hiding this comment.
issue (blocking): We try not to have hard coded strings in our code. If we need this I would suggest exposing a prop for it and defaulting it. Consumers will need to be able to set this value for other languages. We normally use i18n in there somewhere. For example i18nErrorLabel in Alert
| @@ -40,6 +40,7 @@ export const RequiredDot: React.FC<React.PropsWithChildren<RequiredDotProps>> = | |||
| display="block" | |||
| height="4px" | |||
| width="4px" | |||
| position="relative" | |||
Comment on lines
+105
to
+107
| "& [data-paste-element='ICON']": { | ||
| color: "colorTextIcon", | ||
| }, |
There was a problem hiding this comment.
praise: this is cool, I didn't know you could do that!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://paste-docs-git-feat-form-components-changes-twilio.vercel.app/