Skip to content

Clarify the code flow a little bit more #20908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 410 commits into from
Closed

Clarify the code flow a little bit more #20908

wants to merge 410 commits into from

Conversation

chx
Copy link
Contributor

@chx chx commented Apr 22, 2025

Just a few words on the code flow and a potential pitfall.

OskarStark and others added 30 commits February 4, 2025 09:19
* 7.2:
  Replace left over "annotation" by "attribute"
* 7.2:
  [symfony#20337] fix typo
  Replace left over "annotation" by "attribute"
* 7.2:
  Minor tweak
  [Frontend] Correct "Removes comments from CSS" comparison
* 7.2:
  [Mailer] Minor reformating
…n in the `When` constraint (alexandre-daubois)

This PR was merged into the 7.3 branch.

Discussion
----------

[Validator] Add support for the `otherwise` option in the `When` constraint

Fix symfony#20625

Commits
-------

197da33 [Validator] Add support for the `otherwise` option in the `When` constraint
* 7.2:
  Fix 2 small grammar errors/6.4
* 7.2:
  Add a few words about core team member responsibilities
* upstream/7.3:
  Add a few words about core team member responsibilities
  Fix 2 small grammar errors/6.4
  [Validator] Add support for the `otherwise` option in the `When` constraint
  [Mailer] Minor reformating
  Minor tweak
  [Frontend] Correct "Removes comments from CSS" comparison
  [symfony#20337] fix typo
* 7.2:
  [Cache] Fix "Marshalling (Serializing) Data" code rendering issue
* 7.2:
  [Cache] Fix "Marshalling (Serializing) Data" code rendering issue
  Update http client timeout option docs
…orkerOnSignalsListener` in XML config and as plain strings (alexandre-daubois)

This PR was merged into the 7.3 branch.

Discussion
----------

[FrameworkBundle] Allow to pass signals to `StopWorkerOnSignalsListener` in XML config and as plain strings

Closes symfony#20645

Commits
-------

cf1d8f1 [FrameworkBundle] Allow to pass signals to `StopWorkerOnSignalsListener` in XML config and as plain strings
The `role_fetcher` option allows defining a service to fetch user roles from the LDAP server by implementing `RoleFetcherInterface`. This option was introduced in Symfony 7.3, and it supersedes `default_roles` when set. The `MemberOfRoles` implementation can be used to retrieve roles from the `ismemberof` attribute.
…rity configuration (Spomky)

This PR was merged into the 7.3 branch.

Discussion
----------

[Security] Add `role_fetcher` option to LDAP security configuration

Fix symfony#20640

The `role_fetcher` option allows defining a service to fetch user roles from the LDAP server by implementing `RoleFetcherInterface`. This option was introduced in Symfony 7.3, and it supersedes `default_roles` when set. The `MemberOfRoles` implementation can be used to retrieve roles from the `ismemberof` attribute.

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/releases for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `7.x` for features of unreleased versions).

-->

Commits
-------

37e2349 Add `role_fetcher` option to LDAP security configuration
* upstream/7.3:
  Minor tweaks
  Add `role_fetcher` option to LDAP security configuration
  Minor tweaks
  Update http client timeout option docs
  [FrameworkBundle] Allow to pass signals to `StopWorkerOnSignalsListener` in XML config and as plain strings
This PR was squashed before being merged into the 7.3 branch.

Discussion
----------

[Notifier] Add Matrix bridge

Doc PR for
* symfony/symfony#59377

Commits
-------

03b1ed9 [Notifier] Add Matrix bridge
This PR was squashed before being merged into the 7.3 branch.

Discussion
----------

[Console] Add markdown format to Table

Closes symfony#20653

Commits
-------

2f95737 [Console] Add markdown format to Table
* 7.2:
  Add a deprecation notice
  Remove per-property support, dropped in Symfony 7.0
* 7.2:
  Add deprecation notice for propertyName and propertyScope in initializer (Symfony 6.4)
* 7.2:
  [Notifier] Reformat the tables that list the service integrations
* 7.2:
  Make tag aware config examples consistent
* 7.2:
  Bundle example does not implement `CompilerPassInterface`
javiereguiluz and others added 25 commits April 9, 2025 11:30
* 7.2:
  [Scheduler][Webhook] add screencast links
…tory` (kbond)

This PR was merged into the 7.3 branch.

Discussion
----------

[RateLimiter] deprecate injecting `RateLimiterFactory`

Closes symfony#20865.

Commits
-------

fff5293 [RateLimiter] deprecate injecting `RateLimiterFactory`
…clusion from the default services file (Jean-Beru)

This PR was merged into the 7.3 branch.

Discussion
----------

[FrameworkBundle] Remove DI, Entity and Kernel exclusion from the default services file

Since symfony/symfony#59987 and according to the [recipe](https://github.com/symfony/recipes/blob/main/symfony/framework-bundle/7.3/config/services.yaml), the default `config/services.yaml` does not exclude DI, Entity and Kernel file/folders anymore.

Commits
-------

70716ab Update service_container.rst to 7.3
This PR was merged into the 7.3 branch.

Discussion
----------

[RateLimiter] compound rate limiter

Closes symfony#20866.

Commits
-------

35349c1 [RateLimiter] compound rate limiter
* 7.2:
  Minor tweak
  Franken PHP can perform some action after the response has been streamed to the user
…mfony#20836 (sfmok)

This PR was merged into the 7.3 branch.

Discussion
----------

[Validator] Add docs for bridge twig validator symfony#20836

This pull request adds documentation for the new Twig Validator constraint introduced in the Twig Bridge.

Changes:
- Added a page to document the Twig validator constraint, including:
- Installation instructions for the symfony/twig-bridge package.
- Usage of the constraint in Symfony applications.
- Detailed options available, including `message` and `skipDeprecations`.
- Updated `index.rst` to include the new page under the "**Topics**" section for the **Twig Bridge.**

Related Issue:
[Issue symfony#20836 - Add docs for Twig validator](symfony#20836)

Related PR:
[Symfony PR #58805](symfony/symfony#58805) – Introduced the Twig validator constraint in the Twig Bridge.

Commits
-------

ac9e20c Add docs for bridge twig validator symfony#20836
* 7.2:
  Tweaks
  [Serializer] (re)document PRESERVE_EMPTY_OBJECTS
* 7.2:
  Update end_to_end.rst
* 7.2:
  Minor tweaks
  [Deployment] - More accurate local .env file recommendation
* 7.2:
  [HttpFoundation] Add FrankenPHP docs for X-Sendfile
* 7.2:
  Update the links related to X-Sendfile and X-Accel-Redirect
  Update the build script to mention that it does not support Windows
* 7.2:
  Fix a syntax issue in Coding Standards
* 7.2:
  Minor tweak
  feat: swap from event constant to event class
* 7.2:
  Update embedded.rst
* 7.2:
  Update routing.rst
* 7.2:
  [EventDispatcher] Fix a minor syntax issue in a reference
This PR was merged into the 7.3 branch.

Discussion
----------

fix configuration block indentation

Commits
-------

c4cf202 fix configuration block indentation
…CountUnit` options to `File` constraint (alamirault)

This PR was merged into the 7.3 branch.

Discussion
----------

[Validator] Add `filenameCharset` and `filenameCountUnit` options to `File` constraint

Fix symfony#20703

(Inspired by `Length` options descriptions)

Commits
-------

e7613b0 [Validator] Add filenameCharset and filenameCountUnit options to File constraint
This PR was merged into the 7.3 branch.

Discussion
----------

[Routing] document `UriSigner::verify()`

Closes symfony#20904

Commits
-------

aa3b167 [Routing] document `UriSigner::verify()`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.