Skip to content

upgrading libraries #1722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matteocacciola
Copy link

@matteocacciola matteocacciola commented Apr 17, 2025


Important

Update library dependencies in pyproject.toml to newer versions for compatibility and improvements.

  • Dependencies Updated:
    • python version updated to ">=3.10,<3.12".
    • python-dotenv updated to "^1.1.0".
    • pandas updated to "^2.2.3".
    • scipy updated to "1.15.2".
    • matplotlib updated to "^3.10.1".
    • pydantic updated to "^2.11.3".
    • duckdb updated to "^1.2.2".
    • pillow updated to "^11.2.1".
    • jinja2 updated to "^3.1.6".
    • seaborn updated to "^0.13.2".
    • pyarrow updated to "^19.0.1".

This description was created by Ellipsis for b5b0f34. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to b5b0f34 in 1 minute and 36 seconds

More details
  • Looked at 38 lines of code in 1 files
  • Skipped 1 files when reviewing.
  • Skipped posting 9 drafted comments based on config settings.
1. pyproject.toml:15
  • Draft comment:
    Python version updated; ensure your codebase is compatible with 3.10+.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    This comment is asking the PR author to ensure compatibility with a new Python version, which violates the rule against asking the author to ensure behavior is intended or tested. It doesn't provide a specific suggestion or point out a specific issue.
2. pyproject.toml:20
  • Draft comment:
    Matplotlib version constraint changed; verify no breaking changes from older versions.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    This comment is about a dependency change, specifically the version constraint of Matplotlib. According to the rules, I should not comment on pure dependency changes or library versions that I don't recognize. Therefore, this comment should be removed.
3. pyproject.toml:29
  • Draft comment:
    PyArrow updated to ^19.0.1; double-check this upgrade since it might introduce API changes.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    The comment is about a dependency update, specifically PyArrow, and suggests double-checking the upgrade for potential API changes. According to the rules, comments on dependency changes should be ignored unless they are about managing dependencies through the pyproject.yml file. This comment does not mention pyproject.yml, so it should be removed.
4. pyproject.toml:18
  • Draft comment:
    Ensure that upgrading Scipy to 1.15.2 is fully compatible with your code given the significant version jump.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    This comment is asking the PR author to ensure compatibility with a version upgrade, which is against the rules. It doesn't provide a specific suggestion or point out a specific issue with the code.
5. pyproject.toml:24
  • Draft comment:
    Ensure that updated versions for dependencies (e.g. pandas, duckdb, pillow) do not break existing functionality. Update documentation/tests if necessary.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    This comment is asking the PR author to ensure that updated versions of dependencies do not break existing functionality, which violates the rule against asking the author to ensure behavior is intended or tested. It also mentions updating documentation/tests if necessary, which is not specific enough to be useful.
6. pyproject.toml:15
  • Draft comment:
    Updated Python requirement to >=3.10. Ensure documentation reflects this change.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 20% vs. threshold = 50%
    The comment is about a real change in the diff. However, it's asking to "ensure documentation reflects this change" which falls under the rule against asking authors to verify/ensure things. It's also making assumptions about documentation that we can't verify from this diff alone. The version change itself is clear and intentional.
    The Python version change is significant and documentation should be updated, so this could be important for users of the library.
    While documentation updates are important, the comment violates the rule against asking authors to verify/ensure things, and we can't verify the current state of documentation from this diff.
    The comment should be deleted because it asks the author to "ensure" something and requires context outside this file to verify.
7. pyproject.toml:20
  • Draft comment:
    Matplotlib version updated to ^3.10.1, replacing previous bounds. Verify compatibility with existing code.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    This comment is about a dependency version change, which is not something I should comment on according to the rules. The comment asks to verify compatibility, which is also against the rules.
8. pyproject.toml:21
  • Draft comment:
    Pydantic updated to ^2.11.3. Confirm that any schema validations or related logic remain unaffected.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    This comment is asking the PR author to confirm that the update to Pydantic does not affect schema validations or related logic. This falls under the rule of not asking the author to confirm or ensure behavior, which is not allowed. Therefore, this comment should be removed.
9. pyproject.toml:29
  • Draft comment:
    Pyarrow upgraded from ^14.0.1 to ^19.0.1. This is a major jump; please review for any breaking API changes.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    The comment is about a dependency change, specifically the upgrade of the Pyarrow library. According to the rules, I should not comment on pure dependency changes or library versions that I don't recognize. This comment is asking the author to review for breaking changes, which is not allowed. Therefore, this comment should be removed.

Workflow ID: wflow_1ngn5AYHuAXBMotK


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating the versions of libraries
1 participant