-
-
Notifications
You must be signed in to change notification settings - Fork 529
refactor: replace cli-color
with picocolors
#1532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The CI error should be unrelated:
|
CI seems to be broken atm. It uses Even with that; in the new version of the CLI we're using ansis. Can we use that here as well? |
I'm not too familiar with the codebase yet, where should I change?
Didn't notice that, I'll try to replace |
The CI for PRs is here; https://github.com/sequelize/cli/blob/main/.github%2Fworkflows%2Fci.yml With the new version of the CLI, I meant the rewrite that we are doing over in the sequelize/sequelize repo for v7. This sequelize-cli library will be deprecated once that comes out. |
I already tried at And there is a new error:
|
Pull Request check-list
Please make sure to review and check all of these items:
npm run test
pass with this change (including linting)?Description of change
cli-color
->es5-ext
detected as a virusmedikoo/es5-ext#186
And
picocolors
has much lighter weight, no dependencies.