Skip to content

fix: serialize mail object before client dispatch #1123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mayocca
Copy link

@mayocca mayocca commented Apr 7, 2025

Fixes

This PR fixes the call to Sendgrid\Client::makeRequest() within the BaseSendGridClientInterface::send() method. This was caused by the v4.1.2 update to sendgrid/php-http-client mentioned in sendgrid/php-http-client#170 and would fix that issue.

Current test suite covers this fix by ensuring the call to that method works, so no new test cases should be needed.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

@mayocca
Copy link
Author

mayocca commented Apr 13, 2025

Closing as fixed by sendgrid/php-http-client#171

@mayocca mayocca closed this Apr 13, 2025
@mayocca mayocca deleted the fix-email-dispatch branch April 13, 2025 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant