Skip to content

chore: fix php 8.4 deprecation warning #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2025
Merged

chore: fix php 8.4 deprecation warning #169

merged 2 commits into from
Apr 7, 2025

Conversation

tiwarishubham635
Copy link
Contributor

Fixes

Start nullable params with ? to avoid deprecation in PHP 8.4

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket.

@tiwarishubham635 tiwarishubham635 merged commit c859858 into main Apr 7, 2025
33 checks passed
@tiwarishubham635 tiwarishubham635 deleted the php84_fix branch April 7, 2025 11:06
tiwarishubham635 added a commit that referenced this pull request Apr 9, 2025
@tiwarishubham635 tiwarishubham635 mentioned this pull request Apr 9, 2025
8 tasks
tiwarishubham635 added a commit that referenced this pull request Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants