forked from ethereum/go-ethereum
-
Notifications
You must be signed in to change notification settings - Fork 282
SystemContract: support millisecond block generation #1174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
georgehao
wants to merge
5
commits into
develop
Choose a base branch
from
feat/support_ms_block_generation
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -557,9 +557,24 @@ func (w *worker) newWork(now time.Time, parentHash common.Hash, reorging bool, r | |||||
// clique with relaxed period uses time.Now() as the header.Time, calculate the deadline | ||||||
deadline = time.Unix(int64(header.Time+w.chainConfig.Clique.Period), 0) | ||||||
} | ||||||
if w.chainConfig.SystemContract != nil && w.chainConfig.SystemContract.RelaxedPeriod { | ||||||
// system contract with relaxed period uses time.Now() as the header.Time, calculate the deadline | ||||||
deadline = time.Unix(int64(header.Time+w.chainConfig.SystemContract.Period), 0) | ||||||
if w.chainConfig.SystemContract != nil { | ||||||
periodMs := w.chainConfig.SystemContract.Period | ||||||
blocksPerSecond := uint64(1000) / periodMs | ||||||
if blocksPerSecond == 0 { | ||||||
blocksPerSecond = 1 | ||||||
} | ||||||
Comment on lines
+562
to
+565
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can add this as a utility function since it's used in 2 places. |
||||||
|
||||||
// Calculate the actual timing based on block number within the current second | ||||||
blockIndex := header.Number.Uint64() % blocksPerSecond | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
||||||
// Calculate base time and add the fraction of a second based on block index | ||||||
baseTimeNano := int64(header.Time) * int64(time.Second) | ||||||
fractionNano := int64(blockIndex) * int64(periodMs) * int64(time.Millisecond) | ||||||
|
||||||
// Add one period to determine the deadline | ||||||
nextBlockNano := baseTimeNano + fractionNano + int64(periodMs)*int64(time.Millisecond) | ||||||
|
||||||
deadline = time.Unix(0, nextBlockNano) | ||||||
} | ||||||
|
||||||
w.current = &work{ | ||||||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can revert these changes to make total diff smaller.