Skip to content

Improved edit span for import #23083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improved edit span for import #23083

wants to merge 1 commit into from

Conversation

som-snytt
Copy link
Contributor

Left less vertical space when deleting lines of import.

Extracted from local branch of #22316

@som-snytt som-snytt marked this pull request as ready for review May 1, 2025 03:35
tgodzik
tgodzik approved these changes May 2, 2025
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though the code actions do not show up unless the rewrite flag is on. At that point rewrites are doing all the job, so actions are not really needed.

Would it make sense to always produce the actions, just not act on them unless rewrite is on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@som-snytt @tgodzik