Enclosing package p.q not visible as q #23069
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
som-snytt
force-pushed
the
issue/23047-pkg-import
branch
3 times, most recently
from
fca2ca4 to
05fc3cd
Compare
|
It's been a while since I ran the lint on the dotty code base. |
som-snytt
commented
Apr 30, 2025
| end if | ||
| done = true | ||
| else | ||
| return // found enclosing definition, don't register the reference |
There was a problem hiding this comment.
This special handling isn't necessary. Just set a flag for "found enclosing" (so don't register reference), then in outer context it will find the member (for "simple package" or other defs) and not find the "hidden" dotted package name. The latter case won't terminate right away (but that could be fixed).
There was a problem hiding this comment.
Also I already told tpolecat that I deleted the return.
som-snytt
force-pushed
the
issue/23047-pkg-import
branch
from
05fc3cd to
bea7edc
Compare
som-snytt
commented
Apr 30, 2025
| @@ -419,7 +419,7 @@ class CheckUnused private (phaseMode: PhaseMode, suffix: String) extends MiniPha | |||
| candidate = cur | |||
| importer = sel | |||
| else if checkMember(cur.owner) then | |||
| if sym.srcPos.sourcePos.source == ctx.source then | |||
| if sym.is(Package) || sym.srcPos.sourcePos.source == ctx.source then | |||
There was a problem hiding this comment.
package sym has no source to compare.
som-snytt
force-pushed
the
issue/23047-pkg-import
branch
from
bea7edc to
06d1611
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23047
Normally, an enclosing definition always has higher "name binding" precedence than an import, but an enclosing packaging can have a dotted name with a simple name that can't be referenced without qualification or import.
This first cut gives up, but we can infer whether a package was introduced with a dotted name by comparing the owner of the current context with the enclosing package owner.
The second commit does that clever thing (which is not necessarily a good thing).