Set PIP support based on the Picture in Picture API #2849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, picture in picture support was explicitly disabled on iPhones, and used the webkit specific APIs for Safari in general. Safari (both mobile and desktop) has supported the Picture in Picture API since September 15, 2020 (https://caniuse.com/picture-in-picture) so there's no need to use the webkit API. Additionally, picture in picture support appears to work on iPhones with this API, so the check is no longer necessary. Tested on: - iPhone 14 (physical device) - iPad 9th gen (browserstack.com) Negative tests - iPhone 11 (browserstack.com) - predates support but does not raise errorsoes not raise errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of proposed changes
Previously, picture in picture support was explicitly disabled on iPhones,and used the webkit specific APIs for Safari in general.
Safari (both mobile and desktop) has supported the Picture in Picture API since September 15, 2020 (https://caniuse.com/picture-in-picture) so there's no need to use the webkit API.
Additionally, picture in picture support appears to work on iPhones with this API, so the check is no longer necessary.
Tested on:
Negative tests