Skip to content

impl Display for CStr{,ing} #139994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

tamird
Copy link
Contributor

@tamird tamird commented Apr 17, 2025

Delegate to <ByteStr as Display>::fmt.

Link: rust-lang/libs-team#550
Link: #139984.

r? @BurntSushi
cc @Darksonn @tgross35 @ojeda @joshtriplett

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 17, 2025
@tgross35
Copy link
Contributor

tgross35 commented Apr 18, 2025

Could you add a doc comments clarifying what this does for escaping?

Since this requires FCP:
@rustbot label +I-libs-api-nominated

@rustbot rustbot added the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Apr 18, 2025
@tgross35 tgross35 added needs-fcp This change is insta-stable, so needs a completed FCP to proceed. and removed I-libs-api-nominated Nominated for discussion during a libs-api team meeting. labels Apr 18, 2025
Copy link
Contributor Author

@tamird tamird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a doc comments clarifying what this does for escaping?

Done.

ChrisDenton added a commit to ChrisDenton/rust that referenced this pull request Apr 21, 2025
{B,C}Str: minor cleanup

(hopefully) uncontroversial bits extracted from rust-lang#139994.
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 21, 2025
Rollup merge of rust-lang#140118 - tamird:cstr-cleanup, r=joboet

{B,C}Str: minor cleanup

(hopefully) uncontroversial bits extracted from rust-lang#139994.
@bors
Copy link
Collaborator

bors commented Apr 21, 2025

☔ The latest upstream changes (presumably #140127) made this pull request unmergeable. Please resolve the merge conflicts.

@tgross35 tgross35 added the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Apr 21, 2025
Delegate to `<ByteStr as Display>::fmt`.

Link: rust-lang/libs-team#550
Link: rust-lang#139984.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I-libs-api-nominated Nominated for discussion during a libs-api team meeting. needs-fcp This change is insta-stable, so needs a completed FCP to proceed. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants