Skip to content

Add win-arm64 migrator #3194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Apr 21, 2025
Merged

Add win-arm64 migrator #3194

merged 18 commits into from
Apr 21, 2025

Conversation

baszalmstra
Copy link
Contributor

@baszalmstra baszalmstra commented Nov 23, 2024

Description:

This adds a migrator to add win-arm64 builds. I mostly copied the OSXArm migrator. Im unfamiliar with the codebase so I welcome feedback!

Checklist:

  • Pydantic model updated or no update needed

Cross-refs, links to issues, etc:

conda-forge/conda-forge.github.io#1940

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

Attention: Patch coverage is 85.58559% with 16 lines in your changes missing coverage. Please review.

Project coverage is 80.73%. Comparing base (3668b9e) to head (6d3b3ff).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
conda_forge_tick/migrators/cross_compile.py 81.13% 10 Missing ⚠️
conda_forge_tick/migrators/arch.py 78.57% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3194      +/-   ##
==========================================
- Coverage   80.75%   80.73%   -0.03%     
==========================================
  Files         141      141              
  Lines       15972    16073     +101     
==========================================
+ Hits        12898    12976      +78     
- Misses       3074     3097      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Let's add an additional test that runs the migrator on a feedstock and make sure the pinnings repo is setup properly. Then we should be able to merge!

@baszalmstra
Copy link
Contributor Author

@beckermr Is there an example for one of the other arch migrators that I could copy?

@beckermr
Copy link
Contributor

Not specifically for an arch migration but there are good examples in tests/test_migrators.py.

@beckermr
Copy link
Contributor

/relock-conda

@baszalmstra
Copy link
Contributor Author

I have been trying to come up with a test but Im really struggling to grasp how to construct all the different objects at play. If someone has some time, I would love some help with this!

@jakirkham
Copy link
Contributor

Happy New Year! 🥳

Maybe this would be a good item to discuss at the next bot meeting?

@h-vetinari
Copy link
Contributor

AFAIU we need to wait for conda/conda#14401 (and its equivalent for conda-build) to land first

@wolfv
Copy link
Contributor

wolfv commented Jan 15, 2025

Yes, if someone can help us with the appropriate test (or skeleton of tests) that would be highly appreciated.

@beckermr
Copy link
Contributor

beckermr commented Feb 1, 2025

This file has a start of an example of how to test: https://github.com/baszalmstra/cf-scripts/blob/win-arm64-migrator/tests/test_flang.py

You'll likely need to add tests of any .bat files you edit as well.

@isuruf isuruf requested a review from beckermr April 16, 2025 16:42
Copy link
Contributor

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two items otherwise Lgtm.

@isuruf isuruf requested a review from beckermr April 21, 2025 14:47
@beckermr
Copy link
Contributor

Merge when you all are ready!

@isuruf isuruf added this pull request to the merge queue Apr 21, 2025
Merged via the queue into regro:main with commit 964939b Apr 21, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants