-
Notifications
You must be signed in to change notification settings - Fork 80
Add win-arm64 migrator #3194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add win-arm64 migrator #3194
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3194 +/- ##
==========================================
- Coverage 80.75% 80.73% -0.03%
==========================================
Files 141 141
Lines 15972 16073 +101
==========================================
+ Hits 12898 12976 +78
- Misses 3074 3097 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Let's add an additional test that runs the migrator on a feedstock and make sure the pinnings repo is setup properly. Then we should be able to merge!
@beckermr Is there an example for one of the other arch migrators that I could copy? |
Not specifically for an arch migration but there are good examples in |
/relock-conda |
I have been trying to come up with a test but Im really struggling to grasp how to construct all the different objects at play. If someone has some time, I would love some help with this! |
Happy New Year! 🥳 Maybe this would be a good item to discuss at the next bot meeting? |
AFAIU we need to wait for conda/conda#14401 (and its equivalent for conda-build) to land first |
Yes, if someone can help us with the appropriate test (or skeleton of tests) that would be highly appreciated. |
This file has a start of an example of how to test: https://github.com/baszalmstra/cf-scripts/blob/win-arm64-migrator/tests/test_flang.py You'll likely need to add tests of any .bat files you edit as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two items otherwise Lgtm.
Merge when you all are ready! |
Description:
This adds a migrator to add win-arm64 builds. I mostly copied the OSXArm migrator. Im unfamiliar with the codebase so I welcome feedback!
Checklist:
Cross-refs, links to issues, etc:
conda-forge/conda-forge.github.io#1940