Skip to content

Fixes #3705 #3706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: bum-netty-version-to-4_2
Choose a base branch
from
Draft

Conversation

m1ngyuan
Copy link
Contributor

@m1ngyuan m1ngyuan commented Apr 4, 2025

No description provided.

Signed-off-by: Violeta Georgieva <696661+violetagg@users.noreply.github.com>
Signed-off-by: Violeta Georgieva <696661+violetagg@users.noreply.github.com>
@violetagg
Copy link
Member

@m1ngyuan We cannot introduce backwards incompatible changes. I would suggest to wait a bit I have more changes to push. For example the change around SocketProtocolFamily will be something like this:

	/**
	 * Run IO loops on a supplied {@link EventLoopGroup} from the {@link LoopResources} container.
	 *
	 * @param loopResources a new loop resources
	 * @param family a specific {@link InternetProtocolFamily} to run with
	 * @return a new {@link UdpClient} reference
	 * @deprecated Prefer {@link #runOn(LoopResources, SocketProtocolFamily)}
	 */
	@Deprecated
	public final UdpClient runOn(LoopResources loopResources, InternetProtocolFamily family) {
		Objects.requireNonNull(loopResources, "loopResources");
		Objects.requireNonNull(family, "family");
		UdpClient dup = super.runOn(loopResources, false);
		dup.configuration().family = family;
		dup.configuration().socketFamily = family.toSocketProtocolFamily();
		return dup;
	}

	/**
	 * Run IO loops on a supplied {@link EventLoopGroup} from the {@link LoopResources} container.
	 *
	 * @param loopResources a new loop resources
	 * @param socketFamily a specific {@link SocketProtocolFamily} to run with
	 * @return a new {@link UdpClient} reference
	 */
	public final UdpClient runOn(LoopResources loopResources, SocketProtocolFamily socketFamily) {
		Objects.requireNonNull(loopResources, "loopResources");
		Objects.requireNonNull(socketFamily, "socketFamily");
		UdpClient dup = super.runOn(loopResources, false);
		dup.configuration().socketFamily = socketFamily;
		return dup;
	}

@m1ngyuan m1ngyuan force-pushed the netty_4_2 branch 6 times, most recently from 010079c to 0844985 Compare April 5, 2025 10:12
Signed-off-by: Mingyuan Wu <my.wu@outlook.com>
@violetagg violetagg force-pushed the bum-netty-version-to-4_2 branch 10 times, most recently from fa57e51 to d47afef Compare April 14, 2025 07:33
@violetagg violetagg force-pushed the bum-netty-version-to-4_2 branch 3 times, most recently from b755b94 to 3428304 Compare April 22, 2025 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants