Skip to content

Management UI: add a TLS column to the listeners and ports table #13809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

razvanphp
Copy link
Contributor

Proposed Changes

While working on a custom plugin, I found this to be missing. The new cowboy sockets don't appear in Web context, so one does not know if it's TLS or not, except for deriving from the name of the protocol.

Would be nice to add also the Path, but not sure if it's worth the code changes for only the web mqtt/stomp.

Types of Changes

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Here it is how it looks:

Screenshot 2025-04-26 at 19 18 28

@michaelklishin michaelklishin changed the title Add Socket SSL column to management UI Management UI: add a TLS column to the listeners and ports table Apr 26, 2025
michaelklishin added a commit that referenced this pull request Apr 26, 2025
@michaelklishin
Copy link
Collaborator

michaelklishin commented Apr 26, 2025

@razvanphp thank you for contributing. I have renamed the field and column name to say "TLS", tested it with several listeners and merged manually.

Will backport to v4.1.x manually, so this will ship in 4.1.1.

@michaelklishin michaelklishin added this to the 4.1.1 milestone Apr 26, 2025
michaelklishin added a commit that referenced this pull request Apr 26, 2025
(cherry picked from commit c9b2b7f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants