Remove vendored typing-extensions #13336
Conversation
ichard26
added
type: refactor
|
|
||
| if TYPE_CHECKING: | ||
| # TODO: import from typing once Python 3.10 is dropped. | ||
| from pip._vendor.typing_extensions import ParamSpec |
There was a problem hiding this comment.
I think this should import directly from typing_extensions and then add it's to the mypy pre commit additional dependencies:
Line 36 in ab40476
There was a problem hiding this comment.
Yeah, I need to fix the vendoring imports. vendoring is complaining because pip._vendor.typing_extensions does not exist anymore. I'll do that once Rich accepts my PR and cuts a new release.
|
Please be aware of #13313. I have been holding off on merging it, so that I can include any last minute upgrades to our dependencies before the release, but I don't want to get in a merge mess with this. If you're hoping for this to go into 25.1, let me know and I can merge #13313, to give you a stable basis to work from. |
|
Ah, I just noticed this relies on the rich PR, so I imagine it won't make it into 25.1 - that would need the rich PR to land, and a new release of rich, all within a week. |
Yup :) |
It's a shockingly large dependency that does effectively nothing at runtime for us.
Depends on Textualize/rich#3700.