Apply new repo-review suggestion RF003

[DimitriPapadopoulos]

RF003: src directory doesn't need to be specified anymore (0.6+)

Ruff now (0.6+) looks in the src directory by default. The src setting doesn't need to be specified if it's just set to ["src"].

CAVEAT: Removing src = ["src"] results in changes related to the I rules, as suggested by the 0.6.0 release announcement;

By default, our isort rules now search inside src/ directories when determining the list of package names that are likely to represent first-party code. This was always configurable, but it was suprising for many users that Ruff didn't understand this common project structure "out of the box".

This change may result in some of your imports being reordered or recategorised, as import statements that these rules previously considered to be third-party imports will now be correctly understood as first-party.

[notatallshaw]

I tried this myself after seeing the ruff changelog but it produces wrong import sorting, from pip._vendor.* is supposed to be marked as 3rd party as per the config:

known-third-party = ["pip._vendor"]

But this PR moves pip._vendor.* to be first party with pip._internal.*. This is either a bug in ruff or something in the ruff config needs to be updated.

[DimitriPapadopoulos]

Indeed, this doesn't seem right. Pehraps related to astral-sh/ruff#10266.

[notatallshaw]

OP in that issue says known-third-party is a workaround for their issue, but in this example known-third-party is not helping.

It might be the same as this astral-sh/ruff#12984.

[notatallshaw]

ruff still doesn't seem to correctly recognize namespace imports based in the src directory. I don't know exactly which bugs in ruff contribute to this, but without specifying src = ["src"] or manually setting the isort.sections it still doesn't work.

[notatallshaw]

3rd Party Libraries should be in a different group to pip._internal

[notatallshaw]

Vendored packages should be before first-party.