Skip to content

Improve data colors by adding more steps for the colors that can be used on lines and charts #1204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

lukasoppermann
Copy link
Contributor

Summary

  • Adds colors steps 1-4 for each data color
  • All steps have at least a 3:1 contrast ratio against the background

List of notable changes:

What should reviewers focus on?

Steps to test:

@lukasoppermann lukasoppermann self-assigned this Mar 28, 2025
@lukasoppermann lukasoppermann requested review from a team as code owners March 28, 2025 15:27
Copy link

changeset-bot bot commented Mar 28, 2025

🦋 Changeset detected

Latest commit: a6e6376

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 28, 2025

Design Token Diff (CSS)

The message is too long to be displayed here. For more details, please check the job summary.

Copy link
Contributor

github-actions bot commented Mar 28, 2025

Design Token Diff (StyleLint)

The message is too long to be displayed here. For more details, please check the job summary.

Copy link
Contributor

github-actions bot commented Mar 28, 2025

Design Token Diff (Figma)

The message is too long to be displayed here. For more details, please check the job summary.

@github-actions github-actions bot temporarily deployed to Preview (Storybook) March 28, 2025 15:29 Inactive
@langermank
Copy link
Contributor

I feel like we need to do a major for this

@github-actions github-actions bot temporarily deployed to Preview (Storybook) April 4, 2025 12:42 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) April 4, 2025 12:43 Inactive
@lukasoppermann lukasoppermann added the update snapshots Update visual regression test snapshots label Apr 7, 2025
@github-actions github-actions bot removed the update snapshots Update visual regression test snapshots label Apr 7, 2025
@github-actions github-actions bot temporarily deployed to Preview (Storybook) April 7, 2025 09:27 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants