-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Add view text hash info to accessControlReferences #24955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add view text hash info to accessControlReferences #24955
Conversation
@kevintang2022 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@kevintang2022 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@kevintang2022 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@kevintang2022 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@kevintang2022 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@kevintang2022 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@kevintang2022 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Description
In addition to the raw SQL string that the user submitted, checkQueryIntegrity needs to have view definitions used inside the of the query to validate against the credentials passed in through the identity.
Motivation and Context
This is to address the security vulnerability if a view definition gets changed in between when the approved credential was generated and when the query begins executing.
Impact
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.
If release note is NOT required, use: