Skip to content

feat: Add generate_deactivation_script() function in the shell_hook.rs #3670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mrswastik-robot
Copy link
Contributor

@mrswastik-robot mrswastik-robot commented Apr 23, 2025

fixes #3589

This function uses the deactivation() method from the rattler_shell crate, for which I have already created a PR conda/rattler#1278

@Hofer-Julian
Copy link
Contributor

@mrswastik-robot where you able to build this locally with the changes in rattler?

@mrswastik-robot
Copy link
Contributor Author

@mrswastik-robot where you able to build this locally with the changes in rattler?

No, I wasn't 😅! I tried by firstly making changes in the local rattler_shell crate and then giving its absolute path in the Cargo.toml of pixi to use the local crate instead of the installed one. But when I tried to build it, there are a lot of version mismatch issues with rattler_conda_types, maybe because the local version of rattler_shell is using a different version of rattler_conda_types than what the installed rattler_menuinst crate is using. What should be done in this case?

@Hofer-Julian
Copy link
Contributor

What should be done in this case?

The way to do this is to change all rattler crates and point them to your local checkout. Please let me know if that works for you

@mrswastik-robot
Copy link
Contributor Author

What should be done in this case?

The way to do this is to change all rattler crates and point them to your local checkout. Please let me know if that works for you

thanks @Hofer-Julian, I was able to build locally after this

@Hofer-Julian
Copy link
Contributor

Will put this PR as draft until conda/rattler#1278 is merged

@Hofer-Julian Hofer-Julian marked this pull request as draft April 25, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to deactivate environments activated from pixi shell-hook
2 participants