Add 'unique' to model schema - new feature that checks unique constraints when saving/publishing #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
@hyunnbunt is attempting to deploy a commit to the Plasmic Team on Vercel. A member of the Team first needs to authorize it. |
jaslong
reviewed
Feb 25, 2025
jaslong
reviewed
Feb 26, 2025
hyunnbunt
force-pushed
the
addUniqueToModelSchema
branch
from
8c7af54 to
16c87db
Compare
jaslong
reviewed
Apr 4, 2025
jaslong
reviewed
Apr 4, 2025
jaslong
approved these changes
Apr 10, 2025
jaslong
reviewed
Apr 10, 2025
| <Switch | ||
| {...props} | ||
| isDisabled={props.disabled} | ||
| isChecked={props.isChecked && props.value} |
There was a problem hiding this comment.
Do you remember why props.isChecked was added? It caused a bug with the switches not showing the correct state the first time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Unique constraints]
A field can be set to have unique constraint.
When saving an entry's draft data, the unique constraint violation is checked (an endpoint is added)
Upon a publish request, the unique constraint violation is checked for all unique fields. (publish endpoint handles this)
[Details]
The unique constraint only applies to the published entries. It does not affect to draft data of an entry. During auto-saving, the violation status of the most recent values entered by the user in the unique fields are checked. If a violation occurs, a message indicating that publishing is not possible is displayed in the input box, and the publish button is disabled. But Saving is not interrupted.
When a publish request is received, the server checks for violations of all unique fields in the requested entry. If a violation occurs, an error is returned, including a list of the violated fields in the error message. The client uses this information to display a message in the input box indicating that publishing is not possible for the violated fields and disables the publish button.