ext/pdo_pgsql: Delete unused constants #18358
Open
+5
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If that s the case, you need to remove the entries in the related stub too and regenerate using build/gen_stub.php |
devnexen
changed the title
|
Would be good to have a NEWS and above all an UPGRADING entry. |
These constants were added by 6ed1819 but they are not used anymore. They are undocumented which is why I've stumbled upon this.
devnexen
approved these changes
Apr 20, 2025
SakiTakamachi
approved these changes
Apr 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These constants were added by 6ed1819 but they are not used anymore.
They are undocumented which is why I've stumbled upon this.