Skip to content

Approve a PR by leaving "/lgtm" comment #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 43 commits into from
Apr 1, 2025

Conversation

lugi0
Copy link
Collaborator

@lugi0 lugi0 commented Feb 19, 2025

Description

This add a GHA to approve a PR when a user leaves a "/lgtm" comment

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@lugi0 lugi0 requested a review from a team as a code owner February 19, 2025 14:45
Signed-off-by: lugi0 <lgiorgi@redhat.com>
Copy link
Collaborator Author

@lugi0 lugi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing /lgtm

Copy link

The following are automatically added/executed:

Available user actions:

  • To mark a PR as WIP, add /wip in a comment. To remove it from the PR comment /wip cancel to the PR.
  • To block merging of a PR, add /hold in a comment. To un-block merging of PR comment /hold cancel.
  • To mark a PR as approved, add /lgtm in a comment. To remove, add /lgtm cancel.
    lgtm label removed on each new commit push.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
Supported labels

{'/wip', '/verified', '/hold', '/lgtm'}

@lugi0 lugi0 requested a review from rnetser February 19, 2025 15:22
Signed-off-by: lugi0 <lgiorgi@redhat.com>
@github-actions github-actions bot added size/s and removed size/xs labels Feb 19, 2025
Signed-off-by: lugi0 <lgiorgi@redhat.com>
@lugi0
Copy link
Collaborator Author

lugi0 commented Feb 19, 2025

see lugi0#2 for testing of the workflow

@github-actions github-actions bot added size/m and removed size/s labels Mar 14, 2025
@lugi0 lugi0 requested a review from rnetser March 19, 2025 11:07
adolfo-ab
adolfo-ab previously approved these changes Mar 19, 2025
@lugi0 lugi0 requested review from dbasunag and adolfo-ab March 21, 2025 11:15
mwaykole
mwaykole previously approved these changes Mar 24, 2025
adolfo-ab
adolfo-ab previously approved these changes Mar 24, 2025
@lugi0 lugi0 dismissed stale reviews from adolfo-ab and mwaykole via e5fb8ed March 25, 2025 16:00
@lugi0 lugi0 requested review from rnetser, mwaykole and adolfo-ab March 25, 2025 16:01
@lugi0 lugi0 requested a review from rnetser April 1, 2025 11:04
adolfo-ab
adolfo-ab previously approved these changes Apr 1, 2025
@lugi0 lugi0 merged commit d0403ff into opendatahub-io:main Apr 1, 2025
5 of 7 checks passed
Copy link

github-actions bot commented Apr 1, 2025

Status of building tag latest: success.
Status of pushing tag latest to image registry: success.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants