Add support for Linux memory policy #1282
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askervin
requested review from
AkihiroSuda,
crosbymichael,
cyphar,
dqminh,
giuseppe,
hqhq,
kolyshkin,
mrunalp,
thaJeztah,
tianon and
utam0k
as code owners
AkihiroSuda
reviewed
Mar 27, 2025
|
Small nit, I'd suggest to use |
|
LGTM after the changes suggested above |
askervin
force-pushed
the
5aD-oci-mempolicy
branch
from
be4b9f4 to
ee377f1
Compare
Thanks @kad, fixed. Definitely better. |
askervin
force-pushed
the
5aD-oci-mempolicy
branch
from
ee377f1 to
68936b6
Compare
utam0k
reviewed
Apr 1, 2025
There was a problem hiding this comment.
It seems set_mempolicy(2) is only effective agains for called threads. I'm not sure how to do it for processes created with exec. Any ideas?
set_mempolicy() sets the NUMA memory policy of the calling thread,
which consists of a policy mode and zero or more nodes, to the
values specified by the mode, nodemask, and maxnode arguments.
The behavior of several other system calls is the same, so it might be a good idea to define their behavior as well.
I'm not sure but we may need to implement it in nsexec.c of runc because of the thread limitation. I recommend to implement PoC in runc. |
the man page says: so I don't think it is a problem for the spec |
|
@giuseppe Oh, I missed it. Looks good. |
AkihiroSuda
approved these changes
Apr 8, 2025
askervin
added a commit
to askervin/runc
that referenced
this pull request
Apr 16, 2025
Implement support for Linux memory policy in OCI spec PR: opencontainers/runtime-spec#1282 TODO: - remove the replace from go.mod when OCI spec is merged Signed-off-by: Antti Kervinen <antti.kervinen@intel.com>
askervin
added a commit
to askervin/runc
that referenced
this pull request
Apr 16, 2025
Implement support for Linux memory policy in OCI spec PR: opencontainers/runtime-spec#1282 TODO: - remove the replace from go.mod when OCI spec is merged Signed-off-by: Antti Kervinen <antti.kervinen@intel.com>
askervin
added a commit
to askervin/runc
that referenced
this pull request
Apr 16, 2025
Implement support for Linux memory policy in OCI spec PR: opencontainers/runtime-spec#1282 TODO: - remove the replace from go.mod when OCI spec is merged Signed-off-by: Antti Kervinen <antti.kervinen@intel.com>
askervin
added a commit
to askervin/runc
that referenced
this pull request
Apr 16, 2025
Implement support for Linux memory policy in OCI spec PR: opencontainers/runtime-spec#1282 TODO: - remove the replace from go.mod when OCI spec is merged Signed-off-by: Antti Kervinen <antti.kervinen@intel.com>
askervin
added a commit
to askervin/runc
that referenced
this pull request
Apr 16, 2025
Implement support for Linux memory policy in OCI spec PR: opencontainers/runtime-spec#1282 TODO: - remove the replace from go.mod when OCI spec is merged Signed-off-by: Antti Kervinen <antti.kervinen@intel.com>
askervin
added a commit
to askervin/runc
that referenced
this pull request
Apr 16, 2025
Implement support for Linux memory policy in OCI spec PR: opencontainers/runtime-spec#1282 TODO: - remove the replace from go.mod when OCI spec is merged Signed-off-by: Antti Kervinen <antti.kervinen@intel.com>
askervin
added a commit
to askervin/runc
that referenced
this pull request
Apr 17, 2025
Implement support for Linux memory policy in OCI spec PR: opencontainers/runtime-spec#1282 TODO: - remove the replace from go.mod when OCI spec is merged Signed-off-by: Antti Kervinen <antti.kervinen@intel.com>
askervin
force-pushed
the
5aD-oci-mempolicy
branch
from
68936b6 to
a722a43
Compare
askervin
added a commit
to askervin/runc
that referenced
this pull request
Apr 17, 2025
Implement support for Linux memory policy in OCI spec PR: opencontainers/runtime-spec#1282 TODO: - remove the replace from go.mod when OCI spec is merged Signed-off-by: Antti Kervinen <antti.kervinen@intel.com>
utam0k
approved these changes
Apr 21, 2025
askervin
added a commit
to askervin/runc
that referenced
this pull request
Apr 22, 2025
Implement support for Linux memory policy in OCI spec PR: opencontainers/runtime-spec#1282 TODO: - remove the replace from go.mod Signed-off-by: Antti Kervinen <antti.kervinen@intel.com>
askervin
added a commit
to askervin/runc
that referenced
this pull request
Apr 22, 2025
Implement support for Linux memory policy in OCI spec PR: opencontainers/runtime-spec#1282 TODO: - remove the replace from go.mod Signed-off-by: Antti Kervinen <antti.kervinen@intel.com>
askervin
added a commit
to askervin/runc
that referenced
this pull request
Apr 22, 2025
Implement support for Linux memory policy in OCI spec PR: opencontainers/runtime-spec#1282 TODO: - remove the replace from go.mod Signed-off-by: Antti Kervinen <antti.kervinen@intel.com>
askervin
added a commit
to askervin/runc
that referenced
this pull request
Apr 22, 2025
Implement support for Linux memory policy in OCI spec PR: opencontainers/runtime-spec#1282 TODO: - remove the replace from go.mod Signed-off-by: Antti Kervinen <antti.kervinen@intel.com>
askervin
added a commit
to askervin/runc
that referenced
this pull request
Apr 22, 2025
Implement support for Linux memory policy in OCI spec PR: opencontainers/runtime-spec#1282 TODO: - remove the replace from go.mod Signed-off-by: Antti Kervinen <antti.kervinen@intel.com>
askervin
force-pushed
the
5aD-oci-mempolicy
branch
from
a722a43 to
fb37d43
Compare
askervin
added a commit
to askervin/runc
that referenced
this pull request
Apr 23, 2025
Implement support for Linux memory policy in OCI spec PR: opencontainers/runtime-spec#1282 TODO: - remove the replace from go.mod Signed-off-by: Antti Kervinen <antti.kervinen@intel.com>
askervin
added a commit
to askervin/runc
that referenced
this pull request
Apr 23, 2025
Implement support for Linux memory policy in OCI spec PR: opencontainers/runtime-spec#1282 TODO: - remove the replace from go.mod Signed-off-by: Antti Kervinen <antti.kervinen@intel.com>
Enable setting a NUMA memory policy for the container. New linux.memoryPolicy object contains inputs to the set_mempolicy(2) syscall. Signed-off-by: Antti Kervinen <antti.kervinen@intel.com>
askervin
force-pushed
the
5aD-oci-mempolicy
branch
from
fb37d43 to
57c9495
Compare
askervin
added a commit
to askervin/runc
that referenced
this pull request
Apr 23, 2025
Implement support for Linux memory policy in OCI spec PR: opencontainers/runtime-spec#1282 TODO: - remove the replace from go.mod Signed-off-by: Antti Kervinen <antti.kervinen@intel.com>
AkihiroSuda
approved these changes
Apr 23, 2025
This was referenced Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable setting a NUMA memory policy for the container. New linux.mempolicy object contains inputs to the set_mempolicy(2) syscall.