Removed config formatting and env logging (slow) #1647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed config from visualizer (slow) removed dump_config (slow) Removed config from pre_run hook (slow) removed config when saving checkpoint (slow) Revert "removed config when saving checkpoint (slow)" This reverts commit d250e99. Revert "Removed config from visualizer (slow)" This reverts commit 4bd1100. Revert "removed dump_config (slow)" This reverts commit 7036f30. Revert "Removed config from pre_run hook (slow)" This reverts commit 8bfe528. Removed format_python_code
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Logging is really slow, especially while loading and preparing experiments, and saving checkpoints
Modification
I profiled the
train.pyscripts usingpy-spy.I then just commented out the lines that slow down the code as a proof of concept. The user should have the ability to alter these lines with config options.