Skip to content

Update TGI image versions #1749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

xiaotia3
Copy link
Contributor

@xiaotia3 xiaotia3 commented Apr 3, 2025

Description

  • Update TGI CPU/rocm version to v2.4.1
  • Update TGI Gaudi version to v2.3.1

Versions in AvatarChatbot and ChatQnA-ROCm are not updated due to known issues.

Issues

Related to #1563

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

N/A

Tests

git grep text-generation-inference: | grep -v 2.4.1
.github/workflows/scripts/update_images_tag.sh:dict["ghcr.io/huggingface/text-generation-inference"]="docker://ghcr.io/huggingface/text-generation-inference:latest-intel-cpu"
git grep /tgi-gaudi: | grep -v 2.3.1

Signed-off-by: xiaotia3 <xiaotian.chen@intel.com>
Copy link

github-actions bot commented Apr 3, 2025

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

@joshuayao joshuayao linked an issue Apr 15, 2025 that may be closed by this pull request
@joshuayao joshuayao added this to OPEA Apr 15, 2025
@joshuayao joshuayao added this to the v1.3 milestone Apr 15, 2025
@joshuayao joshuayao moved this to In review in OPEA Apr 15, 2025
@joshuayao joshuayao added the v1.3 label Apr 15, 2025
@xiguiw
Copy link
Collaborator

xiguiw commented Apr 16, 2025

@xiaotia3

There are conflicts.
would you please resolve it?

@xiguiw
Copy link
Collaborator

xiguiw commented Apr 17, 2025

@xiaotia3

There are new conflicts.
Please help to resolve it.

@yinghu5 yinghu5 requested a review from Copilot April 18, 2025 03:12
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the TGI image versions across multiple Compose files for various platforms. In particular, it upgrades the Intel CPU images to version 2.4.1, the AMD/GPU (ROCm) images to version 2.4.1, and the Gaudi image to version 2.3.1.

  • Upgrade Intel CPU images for ChatQnA, AvatarChatbot, and AudioQnA from 2.4.0 to 2.4.1
  • Upgrade AMD/GPU (ROCm) images in ChatQnA, AvatarChatbot, AudioQnA, and AgentQnA from versions 2.3.1 (and in one case 3.0.0) to 2.4.1
  • Update documentation in corresponding README.md files to reflect the new image tags

Reviewed Changes

Copilot reviewed 56 out of 61 changed files in this pull request and generated no comments.

Show a summary per file
File Description
ChatQnA/docker_compose/intel/cpu/xeon/compose_tgi.yaml Updated Intel CPU image version for TGI service
ChatQnA/docker_compose/intel/cpu/xeon/compose_faqgen_tgi.yaml Updated Intel CPU image version for TGI FAQ service
ChatQnA/docker_compose/intel/cpu/xeon/README.md Updated documentation with new TGI CPU image version
ChatQnA/docker_compose/amd/gpu/rocm/*.yaml & README.md Updated AMD/GPU (ROCm) image tags to version 2.4.1
AvatarChatbot/docker_compose/intel/hpu/gaudi/*.yaml & README.md Updated Gaudi image to version 2.3.1
AvatarChatbot/docker_compose/intel/cpu/xeon/*.yaml & README.md Updated Intel CPU image to version 2.4.1
AvatarChatbot/docker_compose/amd/gpu/rocm/compose.yaml Updated AMD/GPU (ROCm) image from 2.3.1 to 2.4.1
AudioQnA/docker_compose/intel/cpu/xeon/compose_tgi.yaml Updated Intel CPU image to version 2.4.1
AudioQnA/docker_compose/amd/gpu/rocm/README.md Updated AMD/GPU (ROCm) image tag to version 2.4.1
AgentQnA/docker_compose/amd/gpu/rocm/compose.yaml Updated image version from 3.0.0-rocm to 2.4.1-rocm
AgentQnA/docker_compose/amd/gpu/rocm/README.md Updated documentation with new AMD/GPU (ROCm) image tag
Files not reviewed (5)
  • AudioQnA/tests/test_compose_tgi_on_gaudi.sh: Language not supported
  • AudioQnA/tests/test_compose_tgi_on_xeon.sh: Language not supported
  • AvatarChatbot/tests/test_compose_on_gaudi.sh: Language not supported
  • AvatarChatbot/tests/test_compose_on_rocm.sh: Language not supported
  • AvatarChatbot/tests/test_compose_on_xeon.sh: Language not supported
Comments suppressed due to low confidence (1)

AgentQnA/docker_compose/amd/gpu/rocm/compose.yaml:4

  • The image tag is downgraded from 3.0.0-rocm to 2.4.1-rocm. Please confirm if this downgrade is intentional or if the intended version should be maintained.
image: ghcr.io/huggingface/text-generation-inference:3.0.0-rocm

@chensuyue
Copy link
Collaborator

#1843

@joshuayao joshuayao removed this from the v1.3 milestone Apr 18, 2025
@joshuayao joshuayao removed the v1.3 label Apr 18, 2025
@joshuayao joshuayao added this to the v1.3 milestone Apr 18, 2025
@xiguiw
Copy link
Collaborator

xiguiw commented Apr 18, 2025

TGI Gaudi update to 2.3.1

log from
#1848

whiper load failed.
Transformer version mismatched?

  warnings.warn(
Traceback (most recent call last):
  File "/home/user/comps/third_parties/whisper/src/whisper_server.py", line 116, in <module>
    asr = WhisperModel(
  File "/home/user/comps/third_parties/whisper/src/whisper_model.py", line 27, in __init__
    from optimum.habana.transformers.modeling_utils import adapt_transformers_to_gaudi
  File "/usr/local/lib/python3.10/dist-packages/optimum/habana/__init__.py", line 19, in <module>
    from .transformers import (
  File "/usr/local/lib/python3.10/dist-packages/optimum/habana/transformers/__init__.py", line 20, in <module>
    from .trainer import GaudiTrainer
  File "/usr/local/lib/python3.10/dist-packages/optimum/habana/transformers/trainer.py", line 122, in <module>
    from .training_args import GaudiTrainingArguments
  File "/usr/local/lib/python3.10/dist-packages/optimum/habana/transformers/training_args.py", line 39, in <module>
    from transformers.training_args import (
ImportError: cannot import name '_VALID_DICT_FIELDS' from 'transformers.training_args' (/usr/local/lib/python3.10/dist-packages/transformers/training_args.py)
/usr/local/lib/python3.10/dist-packages/pydantic/_internal/_fields.py:160: UserWarning: Field "model_name_or_path" has conflict with protected namespace "model_".

@lianhao
Copy link
Collaborator

lianhao commented Apr 21, 2025

The whisper-gaudi issue is being tracked by opea-project/GenAIComps#1608

@yinghu5 yinghu5 added the A0 Scrube label Apr 22, 2025
@joshuayao joshuayao removed this from the v1.3 milestone Apr 22, 2025
@joshuayao joshuayao removed this from OPEA Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0 Scrube
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] TGI versions inconsistency / use of old TGI versions
6 participants