-
Notifications
You must be signed in to change notification settings - Fork 0
Improve local only sync #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Job Summary for GradleBuild & Test :: build
|
a215d01
to
2fa07e3
Compare
Job Summary for GradleBuild & Test :: build |
2fa07e3
to
205612f
Compare
@@ -223,6 +266,7 @@ class TaskRepository( | |||
} | |||
if (remoteTaskList != null) { | |||
taskListDao.upsert(remoteTaskList.asTaskListEntity(localTaskList.id, localTaskList.sorting)) | |||
taskListIds[localTaskList.id] = remoteTaskList.id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't ideal for the next step as it would consider this local only list as remote from now on.
In particular, it will query its tasks which aren't there for sure…
This should be refactored another way.
f674a02
to
5412239
Compare
5412239
to
ac610fa
Compare
ac610fa
to
7ed297d
Compare
©️ Stale credits for
|
Description
position
sorting wasn't enforced at DB query levelChecklist