fix(neo-tree): allow neo-tree to hijack netrw on startup #1489
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi, Neo-tree maintainer here.
The Neo-tree spec here has an issue where it lazyloads neo-tree and thus stops neo-tree from being able to hijack netrw until the user opens Neo-tree. this seems like inconsistent behavior from a user perspective.
On recent versions of Neo-tree, manual user-side lazyloading for neo-tree is pretty much unnecessary (all the expensive setup work is delayed until Neo-tree is opened or the command is typed, so startup times should be very minimal when not hijacking on startup), so i'd like to remove the lazyloading here such that users get the intended experience.