Skip to content

Change hash generation #1045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: v3
Choose a base branch
from
Open

Change hash generation #1045

wants to merge 1 commit into from

Conversation

aphralG
Copy link
Contributor

@aphralG aphralG commented Apr 15, 2025

Proposed changes

Change how hash is generated

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@aphralG aphralG self-assigned this Apr 15, 2025
@aphralG aphralG requested a review from a team as a code owner April 15, 2025 16:23
@github-actions github-actions bot added the chore Pull requests for routine tasks label Apr 15, 2025
john-david3
john-david3 reviewed Apr 17, 2025
View reviewed changes
pkg/files/file_helpers.go
hash := sha256.New()
hash.Write(b)

return base64.StdEncoding.EncodeToString(hash.Sum(nil))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason for encoding the hash value in Base64?

@oCHRISo oCHRISo added the v3.x Issues and Pull Requests related to the major version v3 label Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-david3 john-david3 john-david3 left review comments

@NutsaB NutsaB NutsaB approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@aphralG aphralG

Labels
chore Pull requests for routine tasks v3.x Issues and Pull Requests related to the major version v3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aphralG @john-david3 @NutsaB @oCHRISo