-
Notifications
You must be signed in to change notification settings - Fork 127
Revert of #918 with only essential changes, including security enhancements, package updates, Dependabot improvements, testing setup and workflow fixes. #920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@bashleigh could you please review the changes and let us know if anything needs to be updated, or design change needed. |
- Changed update schedule from daily to weekly (Monday 08:00 UTC) - Reduced open PR limit from 10 to 5 to prevent excessive PRs - Grouped minor and patch updates to reduce PR clutter - Enabled auto-merging for minor dependency updates - Added commit message formatting for better tracking - Enabled automatic security updates for vulnerabilities - Assigned reviewers and assignees for better PR visibility - Configured auto-rebasing to avoid merge conflicts This update optimizes dependency management, improves automation, and enhances security tracking.
🔄 Updated Dependabot Configuration (
|
- Removed Coveralls integration from the GitHub Actions workflow - Updated test execution to use npm-run-all2 for parallel test runs - Replaced deprecated docker-compose command with docker compose - Updated actions/checkout to v3 for better security and performance - Ensured Jest coverage report (coverage.lcov) is generated correctly - Improved environment variable handling for consistency This update simplifies the CI workflow by eliminating Coveralls and improving test execution.
🔄 Removed Coveralls & Updated GitHub Actions Workflow📌 SummaryThis PR removes Coveralls from the GitHub Actions workflow and updates it to use ✅ Key Changes
🚀 Benefits
🔍 Next Steps
This update improves workflow efficiency and keeps dependency management clean. 🚀🔥 |
- Set "@bashleigh" as the reviewer for Dependabot PRs - Assigned "@bashleigh" to automatically track and manage updates - Ensures better visibility and faster review process for dependency updates
Hey @Tekvology Love that you want to contribute. Can I request that you make smaller more specific PRs? For a few reasons, mainly I want to minimalise introduction of changes for people's queries and thus create errors. For example adding district is a change that could change someone's query. Let's say there's a 1000 users of this package, then you've introduced 1000 query changes. Secondly, I hardly use nestjs now and I'm struggling to keep up with the decisions I made 3 years ago 😅 sorry if I sound like I'm moaning. Reducing error introduction is important. Especially for this package as I've noticed it happens a lot. Refactoring to use github actions and remove coveralls is a good idea. If you could focus on that in a sperate PR, I'd approve and merge that imediately. Although, not sure on the dataSource change to use memory vs docker. I implemented docker for tests to make sure the tests were effectively replicating the environment the package is likely to be used in. Make sense? Would love some help maintaining this package <3 I've struggled to contribute to open source for a few years now as life gets in the way. |
should probably also add a release method so pakage updates can be pushed out from the repo instead of my local machine (old school I know). Adding codecov is also a great idea! Does codecov also include code complexity ratings? This package could do some complexity reduction? |
isn't cross-env no longer supported? Is there an alternative we can use? |
Tell you what, let's make some issues on the repository and we'll make a board for each one and handle them in a waterfall, agile like fashion? |
What is changing in this PR
Summary of Package Changes
Updated: Test cases and
index.ts
Upgraded Dependencies:
typeorm
→0.3.20
typescript
→5.7.3
ts-jest
→^29.2.5
jest
→^29.0.0
@nestjs/common
→^11.0.1
@nestjs/core
→^11.0.1
@nestjs/testing
→^11.0.1
@nestjs/typeorm
→^11.0.0
Added Dependencies:
"typescript": "^5.7.3"
"rimraf": "^6.0.1"
"rxjs": "^7.1.0"
"sqlite3": "^5.1.7"
"npm-run-all2": "^7.0.2"
"cross-env": "^7.0.3"
Removed Deprecated/old Dependencies:
"coveralls": "^3.0.5"
"rxjs": "^6.5.2"
"ts-jest": "^26.4.4"
"typeorm": "0.3.17"
"typescript": "^4.0.5"
Improvements
coveralls
dependency and few overrides are added to fix security issuesnpm-run-all2
to improve script management.cross-env
to ensuresetup:test
script runs consistently across different environments.sqlite3
to enhance testing speed.This PR enhances project stability, performance, and maintainability while ensuring smooth dependency upgrades and test execution. 🚀