Skip to content

fix(editor): Fix schema view bugs #14734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

elsmr
Copy link
Member

@elsmr elsmr commented Apr 18, 2025

Summary

Schema view bugfix pack

  • Schema view search also filters fields under Variables & Context
  • Fixed spacing on execute node link
  • Select last run with data by default instead of last run
    • Fixes expression previews not working inside a loop
    • Allows removing old hack specific to loop node
  • Fixed collapse/expand behavior when clicking the node title
  • Fixed Variables & Context section sometimes expanding with other nodes
  • Only the first node is expanded by default
  • New empty state when the node has executed, but returned no items
  • Fixed "execute previous nodes" button in schema view empty state
image

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-2829/schema-view-wrong-nodes-shown-etc

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Apr 18, 2025
Copy link

@mrge-io mrge-io bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mrge found 7 issues across 12 files. View them in mrge.io

Copy link

cypress bot commented Apr 18, 2025

n8n    Run #10348

Run Properties:  status check failed Failed #10348  •  git commit f4d65ab312: 🌳 node-2829-schema-view-wrong-nodes-shown-etc 🖥️ browsers:node18.12.0-chrome10...
Project n8n
Branch Review node-2829-schema-view-wrong-nodes-shown-etc
Run status status check failed Failed #10348
Run duration 03m 41s
Commit git commit f4d65ab312: 🌳 node-2829-schema-view-wrong-nodes-shown-etc 🖥️ browsers:node18.12.0-chrome10...
Committer Elias Meire
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 6
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 431
View all changes introduced in this branch ↗︎

Tests for review

Failed  14-mapping.cy.ts • 1 failed test

View Output Video

Test Artifacts
Data mapping > maps expressions from previous nodes Test Replay Screenshots Video
Failed  2372-ado-prevent-clipping-params.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  23-variables.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  9999-SUG-38-inline-expression-preview.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  40-manual-partial-execution.cy.ts • 0 failed tests

View Output

Test Artifacts

The first 5 failed specs are shown, see all 22 specs in Cypress Cloud.

Flakiness  e2e/45-ai-assistant.cy.ts • 1 flaky test

View Output Video

Test Artifacts
AI Assistant::enabled > Should ignore node execution success and error messages after the node run successfully once Test Replay Screenshots Video

Copy link

codecov bot commented Apr 18, 2025

Codecov Report

Attention: Patch coverage is 84.45946% with 23 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ntend/editor-ui/src/components/NodeDetailsView.vue 25.00% 15 Missing ⚠️
...ages/frontend/editor-ui/src/components/RunData.vue 68.42% 6 Missing ⚠️
...rontend/editor-ui/src/components/VirtualSchema.vue 97.10% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant